Summary: | "Find bar" does not search for Arabic text containing "diacritics" | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Hatem Wasfy <ha_wasfy> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED NOTABUG | ||
Severity: | normal | CC: | erack, ha_wasfy, khaled, libreoffice-ux-advise, shinji.enoki, vsfoote, xiscofauli |
Priority: | medium | Keywords: | needsUXEval |
Version: | 6.1.1.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=130603 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 102847, 112810 |
Description
Hatem Wasfy
2018-09-26 06:00:23 UTC
Rather than the <Ctrl>+F "Find bar", does search behave using the <Ctrl>+H "Find & Replace" dialog? IIUC search for diacritics are handled without unicode transformation by ICU libs, but the Find bar and the Finad & Replace dialog get different defaults I tried (Control + H) with untick to the option then it can idetify the word. But (Control + F) still fails. We still need a fix for (Control + F), which is the case that I am reporting bug about. I tried (Control + H) with untick to the option "Diacritic-senstive" then it can idetify the word. But (Control + F) still fails. We still need a fix for (Control + F), which is the case that I am reporting bug about. Out of my wheelhouse... Would this mean the search routines for the Find bar are applying one of the ICU transforms (obscuring the diacritics and other kashida)? OK in the more robust Find & Replace, but misconfigured for the simpler Find bar use? Exactly, It is OK in the more robust Find & Replace, but misconfigured for the simpler Find bar. I could reproduce this issue with the following two versions: Version: 6.1.1.2 Build ID: libreoffice-6.1.1.2-snap1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ja-JP (ja_JP.UTF-8); Calc: group threaded Version: 6.2.0.0.alpha0+ Build ID: d077b30dba618daace0373e9b7e7fe84f982c6aa CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-26_23:17:55 Locale: ja-JP (ja_JP.UTF-8); Calc: threaded I can reproduce in the following environment. OS: OS: Debian jessie x86-64 Version: 6.1.0.3 Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 4; OS:Linux 3.16; UI render: default; VCL: gtk2; Locale: ja-JP (ja_JP.utf8); Calc: group threaded Run in safe mode of LibreOffice I can reproduce it only if 'Complex text layout' in Tools - Options - Language is disabled It's interesting that looking for الناس in firefox doesn't find the text in the arabic text either... Firefox does not support skipping diacritics in search. Very few open source applications do. FWIW, diacritics and other settings are available in the Find & Replace (Ctrl+H) dialog; the Find Bar does not provide these settings. The (IMHO good) design decision was to not inherit the current/last settings from Find & Replace (anymore, it was done once) as that turned out to be too confusing. If additional options are needed they need to be added to the Find Bar. Specifically Diacritics-Sensitive can not be disabled unconditionally (applying a corresponding ICU Unicode transformation) because it interferes with languages where diacritics are distinct characters. Dear Hatem Wasfy, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug Are we OK here with a WONTFIX, and so continue to direct the more robust search into the Find & Replace dialog? Meaning, let's keep the <Ctrl>+F 'Find' toolbar lightweight and continue use of ICU libs for search to be diacritic-insensitive. Annoying for some scripts/locales, but essential to clarity of usage of 'Find' toolbar vs. the 'Find & Replace...' dialog. (In reply to V Stuart Foote from comment #13) > Are we OK here with a WONTFIX Yes. See also bug 130603 and bug 129469. |