Bug 118921

Summary: FILESAVE to .xlsm files with password protection not working (Calc)
Product: LibreOffice Reporter: kam3don
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: aron.budea, drewjensen.inbox, kam3don, silekonn, xiscofauli
Priority: medium Keywords: filter:xlsx
Version: 5.4.7.2 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=118277
https://bugs.documentfoundation.org/show_bug.cgi?id=118938
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 143335    
Attachments: A supposedly password protected read only spreadsheet

Description kam3don 2018-07-24 19:16:31 UTC
Description:
FILESAVE to .xlsm files with password protection not working (Calc)

SAVE WITH PASSWORD (XLSM files) not working. After closing the file, I am able to open it without using any passwords. 

SAVE AS WITH PASSWORD (XLSM files) not working. After closing the file, I am able to open it without using any passwords. 

SAVE OR SAVE AS WITH READ-ONLY PASSWORD AND EDIT PASSWORD OPTIONS SELECTED (XLSM files) not working. After closing the file, I am able to open it, edit, and save without using any passwords. 

Steps to Reproduce:
1. Create a spreadsheet
2. Save to .xlsm format (same thing happens if you do a Save As of a spreadsheet originally saved in a different format).
3. Select the option to password protect (same thing happens if you also add the option to make this read-only and add an additional password for editing).
4. Enter and confirm your password and save the file.
5. Close the file.
6. Open the file, and you will see no password is requested. File opens as if there were no password protection.
7. Even if you originally opted to save as read-only and added an additional password for editing permission, you are still able to edit and save changes on this file. You are never asked for a password for this either.

Actual Results:
I can save an XLSM spreadsheet as password protected, and even as read only with an addition password to allow editing, but when I go to open and edit these supposedly password-protected files, it's as though I had never set any password protection at all.

Expected Results:
In the case of a simple Save/Save As with password protection, I would expect to be asked to enter a password before being allowed to open the file.

In the case of additionally selecting read-only status and adding a separate password to enable editing, I would expect to be asked to enter the read-only password upon attempting to open the file, and to be asked to enter the editing permission password upon attempting to edit the file.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I performed the steps to rest my UserProfile but the problem persisted.

OpenGL is NOT enabled.
Comment 1 kam3don 2018-07-24 19:21:51 UTC
Created attachment 143738 [details]
A supposedly password protected read only spreadsheet

A simple spreadsheet saved as a read only, password-protected XLSM file with an additional editing password.

Read-only password: open
Editing password: edit
Comment 2 Drew Jensen 2018-07-24 20:38:59 UTC
Verified with 5.4.7.2 thru 6.2Master (Ubuntu 18.04)
Comment 3 raal 2019-08-02 16:10:28 UTC
*** Bug 126534 has been marked as a duplicate of this bug. ***
Comment 4 Timur 2021-09-08 11:06:49 UTC
In LO 7.1 and 7.3+ behavior is different with file open password, there's error saving: Write Error. 
Read-only password is working now, bug 118938.
Comment 5 QA Administrators 2023-09-09 03:06:09 UTC Comment hidden (obsolete)
Comment 6 yallabalagan 2024-02-02 06:47:20 UTC
(In reply to QA Administrators from comment #5)
> Dear kam3don,
> 
> To make sure we're focusing on the bugs that affect our users today,
> LibreOffice QA is asking bug reporters and confirmers to retest open,
> confirmed bugs which have not been touched for over a year.
> 

Yes, the bug is still here,
Feb 2nd, 2024, LO version 7.6.4.1, Win 11, 
As commented here by @Timur 2021-09-08 11:06:49 UTC
Trying to save a xlsm file with password protection - gives an error (and does NOT save the file).
Comment 7 yallabalagan 2024-02-02 06:49:37 UTC
(sorry, i accidentally changed the version from 5.4.7.2 to 7.6.4.1.  Resetting it back to when it was discovered)