| Summary: | [WMF] FILEOPEN SELECTPALETTE is not implemented (7-color palette WMF opens black instead in color) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | a246246_246-kde |
| Component: | Draw | Assignee: | Bartosz <gang65> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | gang65, ilmari.lauhakangas, xiscofauli |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | target:7.2.0 target:7.1.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103859 | ||
| Attachments: |
WMF shown in incorrect color.
EMF file opened with MS Word for Mac WMF file exported to PNG by MS Paint WMF sample reduced to a single ellipse with pen and brush from pallete of 2 colors Screenshot of the reduced sample in MS Paint Reduced sample in LO 72.master from May 11, 2021 WMF sample with mixed palette and regular color usage Screenshot for mixed palette and regular colors Comparison LibreOffice 7.1 (KO), LibreOffice 7.2 master (OK) and MSO 2010 |
||
|
Description
a246246_246-kde
2018-06-01 13:06:11 UTC
Created attachment 142476 [details]
WMF shown in incorrect color.
I also send this file to Inkscape project because it looks it has the same bug. https://bugs.launchpad.net/inkscape/+bug/1774430 Those images are to small to give a correct colorpalet Gimp reject the image as to small 1x1 px. not loading Geegie same thing not loading the image Draw give a black image because there is no color info in these small images That is what i think, maybe i am wrong, hope so Please check my analyze for this image on the Inkscape forum above. I see it has 7-color palette. BoundingBox is defined at META_PLACEABLE Record (in WMF spec 2.3.2.3.) I see 0xce 0xfe 0xc2 0xf4 0x31 0x01 0x27 0x00, that means left: -305, top: -2878, right: 305, bottom 39, when interpreted as 16-bit signed integer. Setting to NEW Already in Win 10 LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 Dear a246246_246-kde, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug Repro 7.1+. Created attachment 170553 [details]
EMF file opened with MS Word for Mac
It seems that for Microsoft Word for Mac, EMF file is also not displayed correctly.
Created attachment 170561 [details]
WMF file exported to PNG by MS Paint
The root cause of this issue is missing META_SELECTPALETTE implementation in WMF import. Together with META_CREATEPALETTE it should change the colour properly. Created attachment 171963 [details]
WMF sample reduced to a single ellipse with pen and brush from pallete of 2 colors
As per Bartosz request
Created attachment 171964 [details]
Screenshot of the reduced sample in MS Paint
Created attachment 171965 [details]
Reduced sample in LO 72.master from May 11, 2021
Created attachment 171967 [details]
WMF sample with mixed palette and regular color usage
Created attachment 171968 [details]
Screenshot for mixed palette and regular colors
Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e923f752a3adfe1a941dcbc2fdffc626a569d59e tdf#117957 WMF Add support for selecting colors from palette It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/acf9f22475fa1d35ccbf3576a1d3da9ac8aea1a2 tdf#117957 WMF Add support for selecting colors from palette It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 172092 [details]
Comparison LibreOffice 7.1 (KO), LibreOffice 7.2 master (OK) and MSO 2010
Verified in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: c781776f3c79bbe3175b1452d26c79ebb931a500 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Bartosz, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ? Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9cc47eda70025c6bccfad1cfc45d30b7ecd2fc19 tdf#117957 WMF Fix failing tests on arm64 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9864fbc9d5f532d9aa4742968886b3f94bc44dbc tdf#117957 WMF Replace ellipses with rects to fix tests on arm64 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/a1168e2c58daf2efde944970472c67c46c2e8c03 tdf#117957 WMF Replace ellipses with rects to fix tests on arm64 It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "libreoffice-7-1-4": https://git.libreoffice.org/core/commit/676ba2babff95da3ac41205bc96d1bf252496d6f tdf#117957 WMF Replace ellipses with rects to fix tests on arm64 It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |