Bug 115847

Summary: accessibility: expose menus of menu buttons
Product: LibreOffice Reporter: Samuel Thibault <samuel.thibault>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: jdiggs, jean-philippe.mengual, mgorse, m.weghorn
Priority: medium Keywords: accessibility
Version: 6.0.1.1 release   
Hardware: All   
OS: Linux (All)   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=102046
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 36549    

Description Samuel Thibault 2018-02-19 10:33:30 UTC 
Description:
menu buttons don't show up as menu buttons in the Orca screen reader

Steps to Reproduce:
From swriter, going into Files->Templates->Manage templates to get the Templates dialog box, the "Settings" button on the bottom left corner is a menu button (as seen by the little triangle). 

Actual Results:  
The Orca screen reader however does not know this because the menu that the button would open is not exposed through AT-SPI as a child of the button before clicking the button.

Expected Results:
The menu opened by the button should already be exposed in AT-SPI as a child of the button, before  clicking the button.


Reproducible: Always


User Profile Reset: No



Additional Info:
It seems that in that example, the menu is built in templatedlg.cxx's SfxTemplateManagerDlg::SfxTemplateManagerDlg(), perhaps it is a matter of converting that to .ui?


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Comment 1 Alex ARNAUD 2018-02-20 09:42:40 UTC 
Hello all,

Confirmed on Debian 8.10 Jessie with LibreOfficeDev 6.1 GTK2 and Orca 3.24. FYI, on Windows the issue doesn't appear.

Best regards.
Comment 2 Samuel Thibault 2018-02-20 13:35:38 UTC 
I guess there is no problem on windows because MSAA has ROLE_SYSTEM_BUTTONDROPDOWN, while AT-SPI2 doesn't have that role. Perhaps we should just introduce that role, so that libreoffice can just expose it, instead of orca having to find out that it's a drop-down button?
Comment 3 QA Administrators 2019-02-21 03:42:26 UTC Comment hidden (obsolete)
Comment 4 Samuel Thibault 2019-02-22 16:23:52 UTC 
Yes, I confirm the issue is still there with libreoffice 6.1.5.2, my question still holds: “I guess there is no problem on windows because MSAA has ROLE_SYSTEM_BUTTONDROPDOWN, while AT-SPI2 doesn't have that role. Perhaps we should just introduce that role, so that libreoffice can just expose it, instead of orca having to find out that it's a drop-down button?”
Comment 5 QA Administrators 2021-02-22 03:59:47 UTC Comment hidden (obsolete)
Comment 6 Samuel Thibault 2021-02-22 14:09:59 UTC 
It seems that at least with Libreoffice 7.0.4.2 this is fixed for the provided example:

“
From swriter, going into Files->Templates->Manage templates to get the Templates dialog box, the "Settings" button on the bottom left corner is a menu button (as seen by the little triangle). 
”

On my system, Orca now behaves fine for this example, Jean-Philippe, do you still notice the issue somewhere else in libreoffice 7?
Comment 7 Chris Sherlock 2022-06-30 12:20:17 UTC 
There is no settings in this dialog box any more in LO 7.3.x

Is this still an issue? I tested, seems to be a moot point now.
Comment 8 Michael Weghorn 2023-07-17 09:15:38 UTC 
Closing as WORKSFORME based on comment 6 and comment 7. Please create a new ticket if there are still issues.