Summary: | FILEOPEN: RTF Spacing Totally Lost on Import | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Luke <lukebenes> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | vmiklos, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, filter:rtf, regression |
Version: | 5.4.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=104745 https://bugs.documentfoundation.org/show_bug.cgi?id=104228 https://bugs.documentfoundation.org/show_bug.cgi?id=105729 https://bugs.documentfoundation.org/show_bug.cgi?id=129631 |
||
Whiteboard: | target:5.4.0 target:5.3.0.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 81234 | ||
Attachments: |
Example bulleted list
Same file saved as DOCX correctly handled sample sample2 |
Description
Luke
2016-12-17 22:13:20 UTC
Created attachment 129737 [details]
Same file saved as DOCX correctly handled
I don't think this is a recent regression, I can reproduce it back to LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 with different versions in between. Confirmed in Version: 5.4.0.0.alpha0+ Build ID: 634589b340316ba64b731b4d923c1056be415494 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group Xisco, Sounds like you are confusing this bug with Bug 104745. oh, you're right. I can reproduce this behaviour in Version: 5.4.0.0.alpha0+ Build ID: b29ae3dace6a6a2e24e531bb648cd3cb97ea3225 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-12-14_10:19:59 Locale: ca-ES (ca_ES.UTF-8); Calc: group but not in Version: 5.4.0.0.alpha0+ Build ID: 634589b340316ba64b731b4d923c1056be415494 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group so, as you said, this is a recent regression Miklos, Could you please take a look at this regression? I confirmed that reverting: https://cgit.freedesktop.org/libreoffice/core/commit/?id=657c6cc3acec0528209a8584b838cd6de581c437 tdf#104228 RTF import: fix override of style left/right para margin Causes the bullet lists to once again be indented. The spacing values is still not quite right due to Bug 104745, but I believe that will turn out to be a separate issue. -Luke Adding Cc: to Miklos Vajna *** Bug 104811 has been marked as a duplicate of this bug. *** This regression also affects MS-DOC files. See attachment 129806 [details] / Bug 104811 Attachment 129806 [details] is an RTF file, just with a .doc extension, don't be confused. ;-)
I'll take care of the unexpected 0 margin.
Created attachment 129894 [details]
sample
another file affected
Created attachment 129950 [details]
sample2
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9e029ace41562e28e9242d63230ad1ca275f5d3 tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedup It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified FIXED in Version: 5.4.0.0.alpha0+ (x64) Build ID: bf80bbb7b75febc2769d6b64e6981224982f8fe2 Also tested all of the dupes and samples. RTF filter is looking good. Thank you Miklos! Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d66a9721913e89f1cc76068ee1a64b1cf0eef8d8&h=libreoffice-5-3 tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedup It will be available in 5.3.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |