Bug 131177 - Replace Hard-Coded Tips of The Day's Bulb by Themeable Icon
Summary: Replace Hard-Coded Tips of The Day's Bulb by Themeable Icon
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: reviewed:2022 target:7.6.0
Keywords: difficultyMedium, easyHack, skillCpp, topicDesign
: 154326 (view as bug list)
Depends on:
Blocks: Icon-Themes-Code Tip-Of-The-Day 154106
  Show dependency treegraph
 
Reported: 2020-03-06 07:54 UTC by Rizal Muttaqin
Modified: 2023-03-22 15:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2020-03-06 07:54:52 UTC
Tips of The Day, a feature from 6.3 version show bulb image and somehow with module image element which basically some PNG files and now stored at https://opengrok.libreoffice.org/xref/core/extras/source/tipoftheday/

Please make them theme-able by icon set so it hopefully will blend with the OS
Comment 1 Heiko Tietze 2020-03-06 09:41:09 UTC
Don't like the idea too much. TotD images can be defined on a per tip basis. Meaning "Why not donate to LibreOffice?" could be assigned to an image that shows coins or whatever. Idea was to a) draw attention, and b) illustrate the tip, eg. when talking about "marching ants".

These images are likely not proposed to be themed and therefore placed in an extra folder. If we now make the default bulb a theme image I'm afraid this confuses contributors. More opinions please.
Comment 2 Ahmad Haris 2020-03-06 09:44:31 UTC
I'm agree with theming the icon. And probably we can also create set of icons for Totd.
Comment 3 Rizal Muttaqin 2020-03-06 09:52:57 UTC
(In reply to Heiko Tietze from comment #1)
> Don't like the idea too much. TotD images can be defined on a per tip basis.
> Meaning "Why not donate to LibreOffice?" could be assigned to an image that
> shows coins or whatever. Idea was to a) draw attention, and b) illustrate
> the tip, eg. when talking about "marching ants".
> 
> These images are likely not proposed to be themed and therefore placed in an
> extra folder. If we now make the default bulb a theme image I'm afraid this
> confuses contributors. More opinions please.

Talking about icon theme we had always use fallback strategy. So if we would like to --say-- introduce a new image we could set is as a fallback if a icon theme lack the similar image. 

We should keep in mind also some situation like people with visibility issue which use Sifr icon should not "forced" to use such full-color bulb image. While monochrome color might decrease attention but sure it will help accessibility.
Comment 4 Heiko Tietze 2021-06-14 10:37:34 UTC
So let's do it.

The UI is here cui/uiconfig/ui/tipofthedaydialog.ui, the code there cui/source/dialogs/tipofthedaydlg.cxx
Comment 5 Hossein 2022-08-06 15:21:47 UTC
Re-evaluating the EasyHack in 2022

This enhancement is still relevant. In my opinion, light bulb emoji 💡 can also be used.
Comment 6 Rizal Muttaqin 2022-08-07 07:13:30 UTC
(In reply to Hossein from comment #5)
> In my opinion, light bulb emoji 💡 can
> also be used.

For designing part, I can give hand. So no worries about that.
Comment 7 Commit Notification 2023-03-09 17:07:37 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/49379a0b3fc7b263a7e5be2ecbb018e9248d01f2

Resolves tdf#131177 - Replace Hard-Coded TotD bulb by themeable icon

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Heiko Tietze 2023-03-22 15:41:49 UTC
*** Bug 154326 has been marked as a duplicate of this bug. ***