| Summary: | Pasting SVG bitmap/GDI paste quality worsened (even more) since 7.0/7.1 (affecting also DOCX export) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aron.budea, mikekaganski, stephane.guillou |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=51510 https://bugs.documentfoundation.org/show_bug.cgi?id=138653 https://bugs.documentfoundation.org/show_bug.cgi?id=136047 https://bugs.documentfoundation.org/show_bug.cgi?id=139085 https://bugs.documentfoundation.org/show_bug.cgi?id=140465 https://bugs.documentfoundation.org/show_bug.cgi?id=140768 https://bugs.documentfoundation.org/show_bug.cgi?id=127234 |
||
| Whiteboard: | target:7.2.0 target:7.1.2 | ||
| Crash report or crash signature: | Regression By: | Mike Kaganski | |
| Bug Depends on: | |||
| Bug Blocks: | 103152, 108479 | ||
| Attachments: | Example file | ||
|
Description
Telesto
2020-12-05 19:52:35 UTC
Created attachment 167853 [details]
Example file
Thank you for reporting the bug. I can confirm that the bug is present in Version: 7.2.0.0.alpha0+ Build ID: d9ccee2231a8d8984302e1b2f578bf73b4d60c35 CPU threads: 4; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.0.3.1 Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Additional comments: Paste special bitmap quality significantly reduces between version 7.0.3.1 to 7.2.0.0.alpha0+, the latter one pastes the image in much lower resolution, in this example the image has text and the text can’t be read anymore due to image quality distortion. This deteriorated in two steps, by the following two commits. Adding CC: to Mike Kaganski. https://cgit.freedesktop.org/libreoffice/core/commit/?id=9ff0cd1f6b2200940ac51e580809e2a17c4b9550 author Mike Kaganski <mike.kaganski@collabora.com> 2020-08-24 00:13:19 +0300 committer Mike Kaganski <mike.kaganski@collabora.com> 2020-08-24 04:33:34 +0200 "tdf#136047: fix OutputDevice::DrawTransformBitmapExDirect for ..." https://cgit.freedesktop.org/libreoffice/core/commit/?id=1f5ac5b08fd8c1ddadc5f38595a487db2895957e author Mike Kaganski <mike.kaganski@collabora.com> 2020-08-24 07:56:46 +0300 committer Mike Kaganski <mike.kaganski@collabora.com> 2020-08-24 07:49:02 +0200 "Don't apply transparency twice when drawing to mpAlphaVDev" Both commits reference the following one as the culprit for regressions they're fixing, however this commit didn't have an impact on bitmap paste: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9c621ee8ea41a1c53bfeca49827290826785973e For the record, this a case of something broken before becoming even worse. So the regression part is debatable at minimum :P (probably even 'wrong' in technical sense). I assume the identified commits are not the 'actual' problem.. the image handling being wrong previously.. So this identified commit an existing problem (even) more prominent. Just like for bug 139085, fixed in 7.1 by 058b59ae92ca19beed698ad1a2d6ee6f1182213a, which is a cherrypick of: commit 6b8c157a0b4f37a09fdbf656919b2df06a3abc3e author Luboš Luňák Thu Mar 04 15:35:44 2021 +0100 committer Luboš Luňák Mon Mar 08 13:46:36 2021 +0100 make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111966 Thanks Luboš! ("fixed" as in the quality is back to what in was in 6.4 when following the same steps.) Unrelated to SVG import. Changing metas. |