Bug 39444 - cleanup (very) obsolete types
Summary: cleanup (very) obsolete types
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks:
 
Reported: 2011-07-21 08:29 UTC by Björn Michaelsen
Modified: 2015-12-15 12:16 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2011-07-21 08:29:24 UTC 
==== cleanup (very) obsolete types ====

'''Background:''' There are a number of very obsolete types in use in the code-base.

*'''Already done: '''One is FASTBOOL (defined in [http://opengrok.go-oo.org/xref/libs-gui/tools/inc/tools/solar.h#61 libs-gui/tools/inc/tools/solar.h] which is deprecated and currently defined as int), which should be replaced with a 'bool' type. (But careful: sizeof(bool) = 1 sizeof(FASTBOOL) = 4. So replacing one with the other may not always be trivial and the variable usage should be checked.)

'''Skills:''' build, search & replace.
Comment 1 Gabor Jenei 2011-08-08 03:51:41 UTC 
What do we mean as very obsolete types? And how could I find them all?
Comment 2 Josh Heidenreich 2012-02-21 18:01:48 UTC 
I don't think this exists anymore.

http://opengrok.libreoffice.org/search?q=FASTBOOL&project=core
returns nothing.
Comment 3 Michael Meeks 2012-04-04 08:31:14 UTC 
Marking this fixed for now - no doubt there is more obsolete stuff in tools/ but it needs digging to find it.
Comment 4 Robinson Tryon (qubit) 2015-12-15 12:16:43 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp)
[NinjaEdit]