Bug 161164 - Overline is incorrectly shown for paragraph mark
Summary: Overline is incorrectly shown for paragraph mark
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.8.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest
Depends on:
Blocks: Font-Rendering Formatting-Mark Character
  Show dependency treegraph
 
Reported: 2024-05-18 16:22 UTC by Hossein
Modified: 2024-05-19 11:23 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Text with overline and underline (odt) (13.48 KB, application/vnd.oasis.opendocument.text)
2024-05-18 16:22 UTC, Hossein
Details
zip Test file with screen clips 7.0.6 - 24.8.0 (653.88 KB, application/x-zip-compressed)
2024-05-19 11:23 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hossein 2024-05-18 16:22:00 UTC
Created attachment 194186 [details]
Text with overline and underline (odt)

Description:
If you enable overline for a line of text, overline is also shown (incorrectly) for end of line character. This only happens when you enable showing the formatting marks.

Steps to Reproduce:
2. Open attachment, which is an ODT document
3. Enable unprintable characters with: "Toggle Formatting Marks (Ctrl+F10)" button.

Actual Results:
End of line character, which is a formatting mark is incorrectly overlined in blue. If you disable formatting marks with "Toggle Formatting Marks (Ctrl+F10)", it goes away. This is also true for line break, which is displayed in incorrectly small size.

Expected Results:
End of line character should not be overlined.


User Profile Reset: No

Additional Info:
Reproducible with LO 24.2:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Also reproducible with the latest LO 24.8 dev master:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 551c8230b495e8c0e0502b73445f6edd1510633e
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 V Stuart Foote 2024-05-18 17:04:46 UTC
Confirmed. 

Weird in that while the Para mark has always followed the font of the paragraph, the other 'Font Effects' overline, strikethrough, and underline have changed. 

From LO 3.3.0 all font effects were applied to paragraph end mark. Through at least the 6.4.7 release. But by the 7.3.6 release the strikethrough and underline were removed and the overline remained. Don't have 7.0, 7.1 or 7.2 build handy to test. But a change in there somewhere that didn't get applied to the overline.

Needs a reverse bibisect to find that change, then see if the same handling can be applied to the overline effect.
Comment 2 V Stuart Foote 2024-05-18 17:25:25 UTC
Also, why does the New Line (<Shift>+<Enter> line break with downwards arrow leftwards, looks like U+21B5) *not* get the font size at its position in the paragraph text run? Nor does it get any of the character font effects. What's different for that NPC?
Comment 3 Hossein 2024-05-18 18:53:43 UTC
(In reply to V Stuart Foote from comment #2)
> Also, why does the New Line (<Shift>+<Enter> line break with downwards arrow
> leftwards, looks like U+21B5) *not* get the font size at its position in the
> paragraph text run? Nor does it get any of the character font effects.
> What's different for that NPC?
This is another bug, that I will file.

And thanks for confirming.

Also, one thing to mention is that any solution for this bug should not just copy the way underline is rendered, because in most cases, overline is better (and correctly) rendered, and underline is not. See tdf#155557 comment 10. Paragraph mark is an exception.
Comment 4 V Stuart Foote 2024-05-19 11:23:30 UTC
Created attachment 194191 [details]
zip Test file with screen clips 7.0.6 - 24.8.0

Handling changed in the 7.1 release, between 7.0.6.2 and 7.1.8.1

Also, look at the final para marker before end of page. It picks up the strikethrough and the underline, just like the diminutive new line (<Shift>+<Enter>) marker.