Bug 157796 - Clone Formatting gets disabled in Single Toolbar UI
Summary: Clone Formatting gets disabled in Single Toolbar UI
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Clone-Formatting
  Show dependency treegraph
 
Reported: 2023-10-16 12:11 UTC by liszca
Modified: 2023-10-18 18:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Video Showing "Clone Formatting" can go missing (7.82 MB, video/x-matroska)
2023-10-16 12:16 UTC, liszca
Details

Note You need to log in before you can comment on or make changes to this bug.
Description liszca 2023-10-16 12:11:26 UTC
Description:
When Using UI Variant "Single Toolbar" "Clone Formatting" is not available after having selected an image. But "Clone Formatting" works on the sidebar.

Also "Clone Formatting" works when using UI Variant "Sidebar".

Steps to Reproduce:
1.Paste an Image with your favorit Snipping tool
2.select image
3.then select text formatting should be cloned from

Actual Results:
"Clone Formatting" Button stays grayed out in Menu bar

Expected Results:
"Clone Formatting" Button allows the action to be aplied


Reproducible: Always


User Profile Reset: No

Additional Info:
trying to prepare a short video
Comment 1 liszca 2023-10-16 12:16:15 UTC
Created attachment 190239 [details]
Video Showing "Clone Formatting" can go missing
Comment 2 Kira Tubo 2023-10-17 05:27:36 UTC
Reproduced on: 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

NOT reproduced on:

Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL


To clarify steps:

1. Open calc
2. View > User Interface > Single Toolbar
3. Paste an image
4. Click on pasted image
5. Click on any cell in spreadsheet

Result: "Clone formatting" button is grayed out
Comment 3 Kira Tubo 2023-10-17 06:58:27 UTC
Bibisected win64-7.5. Added Maxim Monastirsky to cc. 

Technically, the issue as originally written in the bug report was introduced in this commit: 
https://git.libreoffice.org/core/+/230a988c9011ffc365070acf9ecd750825b0b1ec

HOWEVER, I noticed that in an earlier commit, you can also disable the Clone Formatting button on the Single Toolbar UI by typing text into a cell, then pressing Enter quickly after typing.
> 1. Open calc
> 2. View > User Interface > Single Toolbar
> 3. Type a letter and then press Enter quickly 

The issue is not reproduced if the user waits a bit, then presses Enter. See video: https://screenpal.com/watch/c06b1pVEhDB

The bug (from the steps above) is introduced at this earlier commit: https://git.libreoffice.org/core/+/48ca2336251d62ac2e90300cd9945fb84b1cddd8

@Maxim Monastirsky, can you take a look at this? It seems both commits were done by you as part of Bug 125040. Thanks!  

--------------------------

commit 48ca2336251d62ac2e90300cd9945fb84b1cddd8	[log]
author	Maxim Monastirsky <momonasmon@gmail.com>	Thu Jun 16 01:07:31 2022 +0300
committer	Maxim Monastirsky <momonasmon@gmail.com>	Thu Jun 16 14:00:12 2022 +0200
tree 6389c48001d96114ed6c00d21dc775a29ecf13dd
parent 970f03cb9ed68d249fe04cff7d4aa15b0f2c6c35 [diff]

-------------------------

commit 0eef8e7f6ee07132c06a2489699941f44becb3f8
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sat Jun 25 00:28:40 2022 -0700

    source 48ca2336251d62ac2e90300cd9945fb84b1cddd8