Bug 146236 - UI Images Properties sidebar shows Columns section
Summary: UI Images Properties sidebar shows Columns section
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords: bibisected, difficultyBeginner, easyHack, implementationError, skillUI
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2021-12-15 09:25 UTC by Gabor Kelemen (allotropia)
Modified: 2021-12-19 08:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file containing an image (35.29 KB, application/vnd.oasis.opendocument.text)
2021-12-15 09:25 UTC, Gabor Kelemen (allotropia)
Details
The Properties sidebar with Columns section (128.23 KB, image/png)
2021-12-15 09:26 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2021-12-15 09:25:29 UTC
Created attachment 176939 [details]
Example file containing an image

When in Writer the Properties sidebar panel is open and you click an image, at the bottom a Columns section appears.

1. Open attached file
2. Click the image
3. Open the Properties deck on the sidebar

A "Columns" section is visible, but images have no columns.
This section should be hidden.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d47628f287f4377394c4ff488c433bfe254b6abe
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Not yet in 7.2.

Bibisected in bibisect-linux-7.3 to:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=dd5bf12193471f064bf7f581dd1b21783390e735

author	Mike Kaganski <mike.kaganski@collabora.com>	2021-06-14 09:51:44 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2021-06-15 10:30:53 +0200

editengine-columns: add sidebar property panel

Adding CC to: Mike Kaganski
Comment 1 Gabor Kelemen (allotropia) 2021-12-15 09:26:07 UTC
Created attachment 176940 [details]
The Properties sidebar with Columns section
Comment 2 Mike Kaganski 2021-12-15 10:12:36 UTC
Code pointer: officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu, see the commit identified in comment 0.
Comment 3 Gabor Kelemen (allotropia) 2021-12-15 16:11:49 UTC
Proposed patch at https://gerrit.libreoffice.org/c/core/+/126888
Comment 4 Commit Notification 2021-12-15 20:29:20 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20301ba19829766eaafc05b06a272865e59fc344

tdf#146236 Hide Columns section in sidebar of Writer images

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-12-16 09:38:20 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/2170fd25b874969579aaee2ccb7834f469c3d6be

tdf#146236 Hide Columns section in sidebar of Writer images

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.