Summary: | Slide Pane should be titled 'Master Slides' when in master view | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
Component: | Impress | Assignee: | Andreas Heinisch <andreas.heinisch> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | admin, andreas.heinisch, heiko.tietze, stgohi-lobugs, xiscofauli |
Priority: | medium | ||
Version: | 4.5.0.0.alpha0+ Master | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=87905 https://bugs.documentfoundation.org/show_bug.cgi?id=91827 |
||
Whiteboard: | target:24.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 102283, 102341 |
Description
Yousuf Philips (jay) (retired)
2014-12-23 15:35:48 UTC
This sounds reasonable and good for me. We're replacing our use of the 'ux-advise' component with a keyword: Component -> LibreOffice Add Keyword: needsUXEval [NinjaEdit] (In reply to Heiko Tietze from comment #3) > Dup of and fixed with bug 87592 This isnt a duplicate and its about the slide pane. (In reply to Yousuf Philips (jay) from comment #4) > This isnt a duplicate and its about the slide pane. Agreed, the "slides" pane's title should depend on whether in master or normal mode. Sounds like an easyhack to me. A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? (In reply to Xisco Faulí from comment #16) > A polite ping, still working on this bug? Apparently not, after a year. Last contribution on Gerrit is also from Jan/2018 Too difficult for me. "Slides" is defined via STR_LEFT_PANE_IMPRESS_TITLE, the LeftPaneImpressChildWindow receives this title in the c'tor at sd/source/ui/dlg/PaneChildWindows.cxx. Could imagine to do something like ::sd::LeftPaneImpressChildWindow->GetWindow()->set_title(<foo>), which doesn't exist, for SID_SLIDE_MASTER_MODE / SID_CLOSE_MASTER_VIEW. The current mode should be easy accessible via "enum class EditMode". Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25d09bdb9f48313c000cc8ec8df60b1bb8efe2e6 tdf#87638 - Modify slide pane title in Impress/Draw based on edit mode It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |