Bug 155094

Summary: Paste transposed does not keep shapes in their cell
Product: LibreOffice Reporter: Regina Henschel <rb.henschel>
Component: CalcAssignee: Regina Henschel <rb.henschel>
Status: VERIFIED FIXED    
Severity: normal CC: buzea.bogdan, info, mikekaganski, stephane.guillou, telesto
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.2.0.0.beta1+   
Hardware: x86-64 (AMD64)   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=68976
Whiteboard:
Crash report or crash signature: Regression By: Roland Kurmann
Bug Depends on:    
Bug Blocks: 108479, 108640    

Description Regina Henschel 2023-04-30 17:35:15 UTC
Open attachment 187015 [details]. Mark the yellow area and copy it to clipboard.
Go to cell L6.
Edit > Paste Special > Paste Special > Transpose All.

Expected: The shapes are inside their cells.

Actual: Green and blue shape are outside the paste area. Red shape is missing.
Comment 1 Telesto 2023-05-01 07:20:16 UTC
Confirm
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 066b23115c2a360507e306a88da572554daefab7
CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2023-05-03 13:50:57 UTC
Repro in recent master build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fb3a6b82b55a298eabf8f431f1451dc826642acd
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Bibisected with linux-64-7.2 repository to first bad commit 0d30bfd69342c502db57e1a3be711741505468a6 which points to core commit:

commit de4c23fb38a7848e1030075b9c15cbb5c558694c
author	scito <info@scito.ch>	Fri May 21 13:11:51 2021 +0200
committer	Mike Kaganski <mike.kaganski@collabora.com>	Fri May 21 17:01:24 2021 +0200
tdf#68976 cut paste transposed: fix wrong position in clipdoc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115535

Roland hasn't been active for a while.
Mike, you participated in the review, any chance you could have a look at it please?
Comment 3 Regina Henschel 2023-05-03 14:14:21 UTC
I'm working in that area for bug 139083, see https://gerrit.libreoffice.org/c/core/+/150161
The patch contains a larger change in the way objects which are included in a cell range are pasted. It should fix this problem here too. Mike, perhaps you have some time to look at that patch?
Comment 4 BogdanB 2023-05-08 05:26:12 UTC
Regina, you can mark this bug as Resolved also here.
Images are well transposed.

Verified in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4f93995f2262cde0b16bacc83f4ba3c6161ada7f
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Bad in
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 5 BogdanB 2023-05-08 11:57:29 UTC
Verified in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4f93995f2262cde0b16bacc83f4ba3c6161ada7f
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded