Bug 153809

Summary: Undo action (Ctrl+Z) does not revert changes to table design formatting
Product: LibreOffice Reporter: Piotr Osada <piotr.osada>
Component: ImpressAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: momonasmon, stephane.guillou
Priority: medium Keywords: implementationError
Version: 7.5.0.0 alpha1+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=94763
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 100366, 105948    
Attachments: 1 Undo is not available.mp4
2 Undo action omitted formating.mp4

Description Piotr Osada 2023-02-24 14:58:09 UTC 
There are some cases where we cannot undo a step. I have noticed that formatting in Impress is not restored after using the undo function (Ctrl+Z).

I've observed this in Impress tables and I'm not sure if this happens across the whole package or just in Impress.

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: pl-PL (pl_PL); UI: en-GB
Calc: threaded
Comment 1 Piotr Osada 2023-02-24 14:58:37 UTC 
Created attachment 185570 [details]
1 Undo is not available.mp4
Comment 2 Piotr Osada 2023-02-24 15:05:29 UTC 
Created attachment 185571 [details]
2 Undo action omitted formating.mp4

The formatting is restored in a different order: it should have been first, but it was reverted after undoing the table style setting operation.

What you don't see in the video: the redo restores all the edits we made before.
Comment 3 Stéphane Guillou (stragu) 2023-03-11 21:37:03 UTC 
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 082d009b6a156faa74c9966b0dffc5fa6ce22287
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Maxim, what do you think? I assume changes to designs should be undoable just like changes to styles.
I tested at f23d3661ab04601650db95f846081317fc06801d and it was already like that back then.
Comment 4 Maxim Monastirsky 2023-03-12 05:30:49 UTC 
(In reply to Stéphane Guillou (stragu) from comment #3)
> I assume changes to designs should be undoable
Absolutely.

> just like changes to styles.
Note that changes to style are neither undoable. This is a general problem in Impress.