Bug 131545

Summary:	FILEOPEN: Document with table takes longer to open than before
Product:	LibreOffice	Reporter:	Xisco Faulí <xiscofauli>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	nemeth, serval2412, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, perf, regression
Version:	7.0.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=125300 https://bugs.documentfoundation.org/show_bug.cgi?id=118991 https://bugs.documentfoundation.org/show_bug.cgi?id=147283
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112700
Attachments:	perf flamegraph

Description Xisco Faulí 2020-03-24 17:02:01 UTC

Steps to reproduce:
1. Open attachment 151278 [details] from bug 118991

it takes

real	0m25,717s
user	0m25,095s
sys	0m0,441s

in

Version: 7.0.0.0.alpha0+
Build ID: 9163755e9f64a0b1dd5f2090e0702c19e31c12c9
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

while in

Version: 6.3.0.0.alpha1+
Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

it takes

real	0m5,004s
user	0m4,382s
sys	0m0,472s

thus, its 5 times slower in master

Comment 1 Xisco Faulí 2020-03-24 17:03:26 UTC

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2c918aa51e5528b090e52fa31b10fa17cf2593ae

author	László Németh <nemeth@numbertext.org>	2019-11-19 21:12:28 +0100
committer	László Németh <nemeth@numbertext.org>	2019-11-21 19:50:25 +0100
commit 2c918aa51e5528b090e52fa31b10fa17cf2593ae (patch)
tree 27bcd35ab6c0929fadb0c44ee88a7a7a3e9e785f
parent 46f8f48ebfe25e26b4d1c0718c772abbee70b889 (diff)
tdf#125300 extend AddParaSpacingToTableCells with line spacing

Bisected with: bibisect-linux64-6.5

Adding Cc: to László Németh

Comment 2 Xisco Faulí 2020-03-24 17:04:15 UTC

@Julien, would it be possible to have a flamegraph for this issue ?

Comment 3 Xisco Faulí 2020-03-24 17:14:01 UTC

I used 'time OOO_EXIT_POST_STARTUP=1 instdir/program/soffice <file>' for the measurement

Comment 4 Julien Nabet 2020-03-24 19:24:54 UTC

Created attachment 158956 [details]
perf flamegraph

Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today.

Comment 5 Timur 2022-05-12 15:25:50 UTC

6.2m 3,36s user 0,57s system 27% cpu 14,278 total
6.4m 2,12s user 0,56s system 17% cpu 15,653 total
7.0m 2,54s user 0,49s system 17% cpu 17,264 total
7.4+ 2,11s user 0,45s system 55% cpu 4,579 total

I think this is WFM. Please retest opening 1st and 2nd time.

Comment 6 Timur 2022-05-12 15:41:08 UTC

5.2m 1st time 2,55s user 0,37s system 19% cpu 14,696 total
5.2m 2nd time 2,68s user 0,24s system 94% cpu 3,102 total

6.2m 1st time 3,27s user 0,52s system 25% cpu 14,991 total
6.2m 2nd time 3,38s user 0,37s system 98% cpu 3,825 total

7.3m 1st time 2,13s user 0,63s system 13% cpu 20,052 total
7.3m 2nd time 2,32s user 0,37s system 99% cpu 2,715 total

7.4+ 1st time 2,59s user 0,40s system 33% cpu 9,010 total
7.4+ 2nd time 2,20s user 0,29s system 97% cpu 2,558 total


I don't see a regression here.

Comment 7 Timur 2022-05-13 07:43:27 UTC

So now is the time as with 43all oldest:
1st time 0,59s user 0,43s system 9% cpu 10,766 total
2nd time 0,76s user 0,30s system 58% cpu 1,798 total