Summary: | A Sentence selection UNO action not provided for assignment to keyboard use | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | V Stuart Foote <vsfoote> |
Component: | LibreOffice | Assignee: | Heiko Tietze <heiko.tietze> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | heiko.tietze, momonasmon, vsfoote, xiscofauli |
Priority: | medium | ||
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bz.apache.org/ooo/show_bug.cgi?id=20126 https://bugs.documentfoundation.org/show_bug.cgi?id=147828 |
||
Whiteboard: | target:6.3.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 86899, 103238 |
Description
V Stuart Foote
2019-04-04 16:47:11 UTC
Isn't shift+<ctrl>+cursor sufficient? (In reply to Heiko Tietze from comment #1) > Isn't shift+<ctrl>+cursor sufficient? No, it selects from current position in _word_ to end of word, and then expands at word bounds. The only functional selection that directly uses _sentence_ boundaries is the L-MouseButton triple click (don't know if it is counting the ButtonDown or ButtonUp). Looks like it is handled per module rather than globally. Here is the Writer handling of it: https://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/edtwin.cxx?#3406 https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/select.cxx?#94 While the triple-click in Impress/Draw Text Box object will select to the Paragraph boundaries. The double-click for Word selection, and the <Ctrl><Shift>+<Cursor> selections do seem the same in a Draw Text Box object. Patch is here https://gerrit.libreoffice.org/#/c/70411, review pending. However, I wonder if we not better take uno::SelectText (Select Text) instead of adding another command. "Select Text" toggles the selection cursor in read-only text (and occupies a shortcut!). The summary is misleading asking for sentence selection while triple click is for the paragraph. Triple click is selects at the Sentence boundaries (not sure if it is ICU lib driven), while Quadruple click selects at the Paragraph boundaries. The UNO commands already existed for WORD and for PARAGRAPH, what is missing (and not addressed in the patch thusfar) is keyboard selection to SENTENCE boundaries. Their selection now is only handled in the sw shell by capturing mouse clicks--see comment 3 Just saw patch set 2, implementing a "Select Sentence"--thanks... heiko tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/180a0688127fc2d3ee337a0c6e38fb573231f3b3%5E%21 Resolves: tdf#124552 - Sentence selection UNO action It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |