Summary: | Undo/redo of text box movement broken | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | muso <uwestoehr> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | dgp-mail, raal, telesto, vmiklos, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, implementationError |
Version: | 6.1.3.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103494, 105948 | ||
Attachments: |
ODT test file
Reproducer document, whithout a textbox. |
The occurs no matter if you move the box to the upper or lower right of the page, the random movement with several undo/redo however only occurs when moving the box to the lower right. I confirm it with Version: 6.2.0.0.beta1 (x64) Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (de_DE); UI-Language: en-GB Calc: threaded Not reproduced in Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.15; Render: default; This seems to have begun at the below commit. Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Thanks fffa2416982cdc322a1c91acdf48e46c391b4c4f is the first bad commit commit fffa2416982cdc322a1c91acdf48e46c391b4c4f Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Tue Aug 7 00:20:18 2018 -0700 source 59f5f666a5085ae58a8dd164636a6bea47e6bddc author Miklos Vajna <vmiklos@collabora.co.uk> 2018-08-06 21:42:32 +0200 committer Miklos Vajna <vmiklos@collabora.co.uk> 2018-08-07 09:14:03 +0200 commit 59f5f666a5085ae58a8dd164636a6bea47e6bddc (patch) tree 2ce2f852b1befcff27f46757f039238590ede889 parent 7d800d0fa98978e06c5dc0f189501f96402e11d5 (diff) tdf#109137 sw textbox: fix initial wrap type of a shape's textbox Sorry, I think this just made existing problem more visible. I'll attach an ODT which has no textbox in it (textbox as in the feature described at https://vmiklos.hu/blog/textbox.html) and the same problem happens there as well: if you just select the shape, press the right arrow then undo, you don't get back the original position. So yes, this is a bug, it has to be fixed, but it's not a regression. Created attachment 147651 [details]
Reproducer document, whithout a textbox.
Reproduce document that shows this was already broken before.
Still in LO 6.3.1.2 (x64) I can no longer reproduce with Version: 6.4.0.3 (x64) Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: CL Many thanks for fixing! I believe this is a duplicate of bug 128782 *** This bug has been marked as a duplicate of bug 128782 *** |
Created attachment 147293 [details] ODT test file - open the attached simple file and move the box "some red text" to the right side - click the undo button result: the movement is not undone since the moved text box lands on a different place - now press the redo button result: the box is placed somewhere else - now press undo then redo a few times and see that the box is placed quite randomly I found out that the bug does not appear when I delete the image in the file so it seems the fact that the file contains an image seems to be important for the bug.