Summary: | FILEOPEN DOCX Document with Form Controls always opens in design mode | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
Component: | Writer | Assignee: | Justin L <jluth> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, jluth, libreoffice, susanjean05, xiscofauli |
Priority: | medium | ||
Version: | 4.4 all versions | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107742 | ||
Attachments: |
Example odt file from LO - works fine
Same content in docx, opens in Design mode Screenshot of the problem Counter example file with dropdown list |
Description
Gabor Kelemen (allotropia)
2018-06-14 13:45:30 UTC
Created attachment 142735 [details]
Same content in docx, opens in Design mode
Created attachment 142736 [details]
Screenshot of the problem
Can't reproduce with Version: 6.1.0.0.beta1 (x64) Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: en-US (de_DE); Calc: CL Was able to reproduce with: Version: 6.0.5.1 (x64) Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751 CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: en-US (en_US); Calc: CL 1) Created new docx file in Writer. 2) Added a label form control and unselected Design Mode. 3) Saved file, ensuring it saves as a docx. 4) Reopened the file and observed Edit->Design Mode. 5) Design mode was selected. Also confirmed with same steps with: Version: 6.2.0.0.alpha0+ Build ID: b1740fba0d1e6e3d69c3781734509317f42a0e4f CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-06-15_08:49:04 Locale: en-US (en_US); Calc: CL Also reproducible in Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.10; Render: default; and Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e Created attachment 142958 [details]
Counter example file with dropdown list
If there is a dropdown list control in the docx file, that file does not open in Design mode.
(In reply to Gabor Kelemen from comment #6) > Counter example file with dropdown list that does not open in Design mode. This example has a true Sdt element (m_pImpl->m_pSdtHelper->hasElements()), so // Form design mode is enabled by default in Writer, not in Word. xFormLayerAccess->setFormDesignMode(false); The example in comment 0 has an OLE checkbox which does not trigger the no-design-mode setting. So that suggests that we need another flag, so that if(xSInfo->supportsService("com.sun.star.drawing.ControlShape")) m_rDomainMapper.hasControls(true); proposed fix at https://gerrit.libreoffice.org/62491 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/8f8d6bee47b5c41ef551e18d2f9d117d82f01e3f%5E%21 tdf#118166 writerfilter: no design mode if ole controls exist It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |