Bug 106367

Summary:	Too much memory used during conditional formatting import
Product:	LibreOffice	Reporter:	Arnaud Versini <arnaud.versini>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED INSUFFICIENTDATA
Severity:	normal	CC:	arnaud.versini, realitix, xiscofauli
Priority:	medium
Version:	5.3.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=106334
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	87351
Attachments:	Memory usage of this allocation

Description Arnaud Versini 2017-03-06 19:45:20 UTC

Description:
Every single conditional formatting uses a table of 8192 pointers during import, for a maximum of tokens of 80192, even if there is only one token in the formula. It's 32KB for x86 and 64kb with x86_64 and could result really fast to a memory. All those tables are keeped with the maximum size during the import.

Steps to Reproduce:
1. Creates a document with a looot of conditional formatting
2. Save it and reopen it


Actual Results:  
crash on 32 bits platforms

Expected Results:
no crash and correct import


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Comment 1 Arnaud Versini 2017-03-06 19:46:09 UTC

Created attachment 131684 [details]
Memory usage of this allocation

Comment 2 Xisco Faulí 2017-03-06 23:01:21 UTC Comment hidden (obsolete)

Hello Arnaud,

Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive information before attaching it. 
See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.)

Comment 3 QA Administrators 2018-01-29 10:27:15 UTC Comment hidden (obsolete)

Dear Bug Submitter,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.
 
Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping-20180129

Comment 4 QA Administrators 2018-03-02 10:05:25 UTC

Dear Bug Submitter,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-20180302