Summary: | Detecting linux distribution and desktop environment | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | buzea.bogdan, heiko.tietze, ilmari.lauhakangas, michael.meeks, momonasmon, robinson.libreoffice, xiscofauli |
Priority: | medium | Keywords: | needsDevEval, topicQA |
Version: | 5.1.0.0.beta1 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103202 |
Description
Yousuf Philips (jay) (retired)
2015-12-12 11:22:48 UTC
Please be careful here ... this data is not just for the help about screen - but also will be reported back to TDF; so we need to be extra careful about adding stuff here. Potentially we should add a parameter 'bool bRich = false' to that method and its uses so we can distinguish 'help->about' from the update script. Fine to add things if you do that - and they're only there for the bRich setting =) Yes if this data isnt useful for reporting to TDF, then it would be only needed in the about dialog, where it would be invaluable to QA, so when linux users copy and paste the about dialog info into bug reports, we wouldnt need to follow up with them on which distribution and desktop environment they are running (e.g. bug 81441, bug 98040). I noticed that we do have Application::GetDesktopEnvironment() which does return some desktop environments like unity, kde3, kde4 and kde5, though i'm not sure how accurate this is. There is no inxi by default on Arch Linux. "lsb_release -a" could return the distribution LSB Version: 1.4 Distributor ID: Arch Description: Arch Linux Release: rolling Codename: n/a (maybe "lsb_release -d -s") $XDG_CURRENT_DESKTOP holds the desktop variable ("KDE" in my case); but now I can run my own theme... But the question is: Do we need this for QA. What do you think, Xisco? |