Summary: | [1] space as intersection in Excel A1 (or R1C1) formula syntax gives Err:509 or Err:508 | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Bob Briscoe <bob> |
Component: | Calc | Assignee: | Eike Rathke <erack> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | h3734236, ilmari.lauhakangas |
Priority: | medium | ||
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:5.2.0 target:5.1.4 target:5.4.0 target:5.3.4 | ||
Crash report or crash signature: | Regression By: |
Description
Bob Briscoe
2015-12-11 20:13:46 UTC
Reproduced. Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: fi-FI (fi_FI) Oh yeah, conditionally significant whitespace as operator, great fun.. also in OOXML. One has to bow before the wisdom of Excel devs. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=26adceb098134d918f6d57c8687ab057e24adc39 Resolves: tdf#96426 significant whitespace as intersection in Excel syntax It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b0992e11905e36a64edeb92a13acfde5837c1878 fully check for adjacent RPN end, tdf#96426 follow-up It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0875f8e348a3aca036bc0cc629fb038fabc8062 narrow down where a space could be an intersection, tdf#96426 follow-up It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Also https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f8a8332a52cd03b43aaab86e0c232e0964d7111 Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c5663cfb13f4f55e246d42ac464d5e2c2f23099 first range can be anywhere before second at RPN end, tdf#96426 follow-up It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/24374 for 5-1 (In reply to Eike Rathke from comment #8) > Pending review https://gerrit.libreoffice.org/24374 for 5-1 Thx for the fix. I'll test the daily build as soon as I can, using our cashbook spreadsheets, which liberally use the intersection operator in Excel formula syntax. I'll also try to contrive some more challenging tests. However, I have bigger problems at the mo, which I need to fix first (crash while not even touching my machine left me with black-screen on boot). So prob a fortnight. I'm afraid I cannot review the code. I've had a quick look at your diffs, but I'm completely unfamiliar with Libre Office code, so I won't promise to review it - would be pointless. (In reply to Bob Briscoe from comment #9) > I'm afraid I cannot review the code. I've had a quick look at your diffs, > but I'm completely unfamiliar with Libre Office code, so I won't promise to > review it - would be pointless. It's ok - we are not expecting you to review it :) If you are interested in contributing without coding, see https://wiki.documentfoundation.org/QA/Triage_For_Beginners for an intro to the vast world of quality assurance. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=edd4370f5ba49a26a526995b6a28f623d68041ce check presence of token, tdf#96426 follow-up It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b8d78268d1c58557122f99d6134a3b1eda7fe6c3&h=libreoffice-5-1 Resolves: tdf#96426 significant whitespace as intersection in Excel syntax It will be available in 5.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. THank you for trying to fix this, but it's not completely fixed, I'm afraid. The fix works with intersections between simple cell ranges, but you get the two errors described in the original bug report when the intersection is defined between variable names (defined as cell ranges using Insert>Names>Define). See the screenshots at http://homefarmparham.co.uk/tmp/calc/IntersectCalcBugReopen.html in which the red text has been added since the original bug report. For instance, if you define: * horiz as Sheet1!$2:$2 * vert as Sheet1!$B:$B Then, with Excel A1 formula syntax, the following example formulae return the errors shown: =(vert horiz)*2 Err:508 (pair missing) =vert horiz Err:509 (missing operator) _______ I just noticed an extra twist: If an intersection formula is written with a '!' when Calc A1 formula syntax is selected, e.g.: =(vert!horiz)*2 a) this works correctly with no errors. b) the '!' correctly auto-translates to a ' ' (space) if the formula syntax is switched to Excel A1. c) And there are still no errors, but... d) ...if the formula is edited to a different formula with ' ' (space) as an intersection operator, the bug re-appears. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=70cb7757f971c4c16d1b0a5585d95816cd4382e6 Resolves: tdf#96426 more whitespace intersection operator in Excel syntax It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/37712 for 5-3 Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=67a4bb2204c841bf468504fcf5282787abc0e973 add unit test for Excel whitespace operator intersection, tdf#96426 It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8326c48a1ac4855970f9232dba582a51461ac0b2 Unit test to ensure that calculating with the intersection works, tdf#96426 It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c89d41ed44c1a4126b82f0c05768f5d640f741b&h=libreoffice-5-3 Resolves: tdf#96426 more whitespace intersection operator in Excel syntax It will be available in 5.3.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |