Summary: | Cleanup: Replace imageproducer with CommandInfoProvider | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt> |
Component: | framework | Assignee: | Susobhan Ghosh <susobhang70> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | h3734236, jmadero.dev, robinson.libreoffice, samuel.mehrbrodt |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:5.1.0 target:5.2.0 | ||
Crash report or crash signature: | Regression By: |
Description
Samuel Mehrbrodt (allotropia)
2015-11-25 11:16:45 UTC
Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=02044b5d2711e837cfc8680a265614e138e79d86 tdf#96059 Replace imageproducer with CommandInfoProvider It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Can this be set to fixed? No, comment 1 was only an example commit. There are lots of other places where this needs to be done. Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner, SkippCpp -> skillCpp, TopicCleanup ) [NinjaEdit] Hi! This is my first bug fix. I'm a new contributor. I've successfully build LO, and tried git grep imageproducer. I've doubts regarding this specific GetImageFromURL call in http://opengrok.libreoffice.org/xref/core/framework/source/classes/menumanager.cxx#232 How do I change this to the specified function call? There are two parameters given. The example commit doesn't help with that. (In reply to Susobhan Ghosh from comment #5) > Hi! This is my first bug fix. I'm a new contributor. I've successfully build > LO, and tried git grep imageproducer. > > I've doubts regarding this specific GetImageFromURL call in > http://opengrok.libreoffice.org/xref/core/framework/source/classes/ > menumanager.cxx#232 > > How do I change this to the specified function call? There are two > parameters given. The example commit doesn't help with that. Never mind. I got it. Will be pushing changes soon. I'm assigning this to myself. susobhang70 committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c39b28a87060f80404079ab77604f664addb063 tdf#96059 Replaced imageproducer with CommandInfoProvider It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #8) > susobhang70 committed a patch related to this issue. > It has been pushed to "master": > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=5c39b28a87060f80404079ab77604f664addb063 > > tdf#96059 Replaced imageproducer with CommandInfoProvider > This commit created a regression in the File->New menu, because the entries there aren't .uno command. This particular case should be changed to SvFileInformationManager::GetImageNoDefault, instead of CommandInfoProvider. Susobhan Ghosh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=51b71a7be13611acc02a702cf025425fc746f4a2 Related tdf#96059 Fix icons in File->New menu It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit] |