| Summary: | FILESAVE: Roundtrip any PPTX file with Shapes creates invalid OOXML | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Luke <lukebenes> |
| Component: | Impress | Assignee: | Tamás Zolnai <zolnaitamas2000> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | h3734236, raal, stgohi-lobugs, timar74, zolnaitamas2000 |
| Priority: | medium | Keywords: | bibisected, bisected, filter:pptx, regression |
| Version: | 4.4.0.0.alpha0+ Master | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.2.0 target:5.1.0.2 target:5.0.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Original with just a Rectangle
Correctly roundtripped with 4.3 Error when roundtripped with 5.1 |
||
Created attachment 120776 [details]
Correctly roundtripped with 4.3
Created attachment 120777 [details]
Error when roundtripped with 5.1
Reproducible with LO 5.0.3.2, Win 8.1 This seems to have begun at the below commit. Adding Cc: to Zolnai Tamás ; Could you possibly take a look at this one? Thanks a517caa859adca6b8c80c8529bfe7bfb68c61ddf is the first bad commit commit a517caa859adca6b8c80c8529bfe7bfb68c61ddf Author: Matthew Francis <mjay.francis@gmail.com> Date: Sun Mar 15 02:49:47 2015 +0800 source-hash-b3d50feaa87b670baf68288974005ac26ad31736 commit b3d50feaa87b670baf68288974005ac26ad31736 Author: Zolnai Tamás <tamas.zolnai@collabora.com> AuthorDate: Tue Sep 16 17:51:12 2014 +0200 Commit: Zolnai Tamás <tamas.zolnai@collabora.com> CommitDate: Wed Sep 17 09:59:50 2014 +0200 bnc#584721: Import subtitle block to master slides For some reason subtitle block was skipped for layouts. It seems we can enable it for layout too, it appears well on master slides. Change-Id: I23ec7d4fcce045099bfca9e94a8c9335beaf7468 *** Bug 95166 has been marked as a duplicate of this bug. *** Bumping this to major because a) it involves a "loss of function" b) marked older Bug 95166 as a dupe and someone else considered that one to be major. *** Bug 92221 has been marked as a duplicate of this bug. *** Andras was CC'd on a dupe and has done a ton of work in this area. Feel free to remove. Migrating Whiteboard tags to Keywords: (bibisected) Zolnai Tamás committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9db17aabc3ac970e6e4754e28310d20138144d9 tdf#96051: FILESAVE: Roundtrip any PPTX file with Shapes creates invalid OOXML It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified FIXED in Build ID: 4251e676bb818cde1989b9077b1497f1d9b0cbdc Thank you Zolnai. Any idea why the subtitle block causes Impress to generate such different OOXML in files with shapes? Zolnai Tamás committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe9971de7e792960dc88fc562f2db04fee48cc2d&h=libreoffice-5-1 tdf#96051: FILESAVE: Roundtrip any PPTX file with Shapes creates invalid OOXML It will be available in 5.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Luke from comment #11) > Verified FIXED in Build ID: 4251e676bb818cde1989b9077b1497f1d9b0cbdc > > Thank you Zolnai. Any idea why the subtitle block causes Impress to generate > such different OOXML in files with shapes? No idea. Zolnai Tamás committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e18c062be49042945644db438608a6e58c7dc98a&h=libreoffice-5-0 tdf#96051: FILESAVE: Roundtrip any PPTX file with Shapes creates invalid OOXML It will be available in 5.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 120775 [details] Original with just a Rectangle Any OOXML presentation with shapes will be corrupted on roundtrip with Impress >= 4.4. Steps to reproduce: 1. In PowerPoint create a presentation. 2. Insert shape 3. Save 4. Open in Impress <= 4.3 5. Save 6. Open in PowerPoint 7. Repeat 4-7 with Impress > 4.3 With Impress 4.4 and newer, PowerPoint reports that it "Found a problem with the content and can attempt a repair."