| Summary: | getDisplayDirectory returns an empty string for Windows filepicker | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
| Component: | BASIC | Assignee: | Regina Henschel <rb.henschel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | h3734236, oliver.brinzing, raal |
| Priority: | medium | ||
| Version: | 5.1.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:5.1.0 target:5.0.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Macro with getDisplayDirectory | ||
The error is in file core\fpicker\source\win32\filepicker\VistaFilePicker.cxx; method VistaFilePicker::getDisplayDirectory(); line#249 - const OUString sDirectory = rRequest->getArgumentOrDefault(PROP_FILENAME, OUString()); + const OUString sDirectory = rRequest->getArgumentOrDefault(PROP_DIRECTORY, OUString()); patch is waiting in https://gerrit.libreoffice.org/#/c/18127/ . Regina Henschel committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8775593bcc543b3d7021e20736f42fa13035870d tdf#93634 repair getDisplayDirectory for Windows filepicker It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #3) > Regina Henschel committed a patch related to this issue. > It has been pushed to "master": > Setting as RESOLVED FIXED Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a023cd66e74a96aec52d891508cd757292513401&h=libreoffice-5-0 tdf#93634 repair getDisplayDirectory for Windows filepicker It will be available in 5.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 118131 [details] Macro with getDisplayDirectory Set LibreOffice to use its own filepicker dialog for Open/Save. Run the attached macro "ExamineFileDialog". Notice you get directory name and file name, each surrounded with | character. Now set LibreOffice to use Windows filepicker dialog. Run the macro again. Notice, that the directory name is empty. It makes no difference whether you use oFileDialog.DisplayDirectory or oFileDialog.getDisplayDirectory or oFileDialog.getDisplayDirectory(). This is likely on old bug, inherit from OOo, but I do not find a bug report. This bug affects the use of HelpAuthoring.oxt on Windows.