Summary: | Clicking in the text or using Enter key does not move the cursor anymore | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jean-Baptiste Faure <jbfaure> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | CLOSED FIXED | ||
Severity: | critical | CC: | cno, h3734236, ilmari.lauhakangas, lo, michael.stahl, miles |
Priority: | highest | Keywords: | regression |
Version: | 5.0.0.0.beta1 | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=91602 | ||
Whiteboard: | target:5.1.0 target:5.0.0.0.beta3 | ||
Crash report or crash signature: | Regression By: |
Description
Jean-Baptiste Faure
2015-06-07 06:35:17 UTC
Worked one day ago ==> regression Works as expected if I go back to this commit: Version: 5.0.0.0.beta1+ Build ID: 1b3d17ba7cd45dc0431b9b1809d908a7a066d9a1 Ubuntu_15.04_x86-64 Locale: fr-FR (fr_FR.UTF-8) Best regards. JBF Well, the problem is in this commit: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=4ae19cf8435d78bec75e1c4ea95da9f0aaf35b62 author Michael Stahl <mstahl@redhat.com> Fri, 5 Jun 2015 23:56:07 +0200 (23:56 +0200) committer Michael Stahl <mstahl@redhat.com> Sat, 6 Jun 2015 00:35:56 +0200 (00:35 +0200) SwCrsrShell::UpdateCrsr() calls SwTextFrm::GetCharRect(), which does layout. It happens that a SdrObject is moved around during layout, which calls SwDrawContact::Changed(), which believes that there is no layout active because there is no SwLayAction and ViewShell::EndAction() has already been called, so we get recursive layout-in-layout action. Change-Id: Iad8df4910e3c661150bdf5ac7d777792e69a8f71 (cherry picked from commit 587006cac508616f486aea45e265a170bcccdc87) Works as expected until the previous commit: Build ID: 4d8acde1b820c2548839b1632bc28f2988001941 Best regards. JBF Additionally: the Enter key create a new paragraph (visible if you show the non printable characters) but does not move the cursor in front of this new paragraph. That make working with this build of LO-Writer not possible. So increasing the severity. ==> blocker. Best regards. JBF Confirmed. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: be8512f99bc9ab18e55aabe01cc0ab1e6baea9e6 TinderBox: Win-x86@39, Branch:master, Time: 2015-06-08_05:58:40 Locale: fi-FI (fi_FI) Ubuntu 15.04 64-bit Version: 5.1.0.0.alpha1+ Build ID: 47cddc662efc470505f0b76427fa3092bae5550a TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-06-07_00:54:53 Locale: en-US (en_US.UTF-8) osx 10.10.3 latest nightly from today confirmed. OS → all this is a blocker. comment #4 -> summary adapted. Best regards. JBF oops, fixed on master Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=238e07ddca879e0951bef6391fdc5c3fc26bded5 tdf#91917 tdf#91602: avoid layout recursion differently It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=73b303fc3693e7cdf457e617c252c10ef4620bd9&h=libreoffice-5-0 tdf#91917 tdf#91602: avoid layout recursion differently It will be available in 5.0.0.0.beta3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you very much ! Verified fixed in Version: 5.0.0.0.beta2+ Build ID: 45e1b4cad938a8ac1c865df527dcc536d4c80920 Ubuntu_15.04_x86-64 Locale: fr-FR (fr_FR.UTF-8) built at home. Best regards. JBF Problem is gone now. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: d28102b1ed0c31500bbc68453a7b7613bd2bfa06 TinderBox: Win-x86@39, Branch:master, Time: 2015-06-09_01:06:39 Locale: fi-FI (fi_FI) fixed on osx as well. Thanks. *** Bug 91977 has been marked as a duplicate of this bug. *** *** Bug 91928 has been marked as a duplicate of this bug. *** |