Summary: | Images embedded in password protected document are lost on save | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Peter Ryan <peterx14> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | VERIFIED FIXED | ||
Severity: | major | CC: | fdbugs, jbfaure, jmadero.dev, leorickg, matus, raal |
Priority: | highest | Keywords: | bibisected, bisected, regression |
Version: | 4.4.1.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | target:4.5.0 target:4.4.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 79641 | ||
Attachments: | file with picture, password "a" |
Description
Peter Ryan
2015-03-14 21:34:43 UTC
I can not confirm with LO 4.4.1.2, win7. PNG image. I just tried a PNG and it also worked perfectly. Then tried again with a Jpeg (a different one from before) and it failed. I shouldn't have assumed it would be all image types! I can confirm with Version: 4.5.0.0.alpha0+ Build ID: 7f3628e54d4470cac6d51659d1b1bec5fb4f4e70 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-03-14_00:35:32 JPG image When I click on picture(read error) and select compress image from menu then LO crash. Dataloss, higher importance. Works OK in LO 4.3-> regression Created attachment 114142 [details]
file with picture, password "a"
This seems to have begun at the below commit. Adding Cc: to matus@libreoffice.org; Could you possibly take a look at this? Thanks commit 0843ade74e5848c0babad509b10c334b01847be2 Author: Matúš Kukan <matus.kukan@collabora.com> AuthorDate: Wed Nov 12 21:25:55 2014 +0100 Commit: Matúš Kukan <matus.kukan@collabora.com> CommitDate: Mon Nov 17 10:49:24 2014 +0100 package: Do not bother with deflating jpeg images It takes a lot of time and we can save ~1% of size if at all. Rather store them uncompressed in the zip file. With png, we can save a bit more, although it's still only about 4% - 8%? Change-Id: I43a3e3812882e4ce85e7af9d0aaab454d98c4860 I can Confirm this bug as I am having such problems with version 4.4.12. I think this bug started with version 4.4. I don't remember having this issue with version 4.3 At first I thought it was my images. But they are saved locally on my storage drive and I only use JPG and PNG. I tried and tested both as I thought that it was a file format issue. Most of the images are from the web, so it's mixed JPG and PNG. I did not thought about the password though. All my ODT files are password protected as I share my computer with my sister. I didn't think that it would cause such an issue. This is a critical bug since loosing images that I attach to reports for clients and customers will be gone and re-attaching takes time. I'm running Windows 7 Pro 64-bit and LO 4.4.12 I'm hoping that it will get fixed soon in the following RC. Thank you very much ^_^ *** Bug 90034 has been marked as a duplicate of this bug. *** Good MAB candidate. Regression, bibisected, QA has done everything it can. Adding now. (In reply to Matthew Francis from comment #5) > This seems to have begun at the below commit. > commit 0843ade74e5848c0babad509b10c334b01847be2 > Author: Matúš Kukan <matus.kukan@collabora.com> > > package: Do not bother with deflating jpeg images > > It takes a lot of time and we can save ~1% of size if at all. Rather > store them uncompressed in the zip file. > With png, we can save a bit more, although it's still only about 4% > - 8%? Oh, what fun! Nice catch! I was not testing password protected documents. OK, I will try to check what happens there. In worst case, my commit was just performance improvement and can be reverted (when storing with password). Matúš Kukan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca5ff4559726455d0c8fbdd08cb35af3308492bf tdf#90010 Partially revert "package: Do not bother with deflating jpeg images" It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Matúš Kukan committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=da651b6ccb47e82f71d890fc8bb9d6cf0201f289&h=libreoffice-4-4 tdf#90010 Partially revert "package: Do not bother with deflating jpeg images" It will be available in 4.4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in master and in LibreOffice 4.4.3.0.0+ both built at home under Ubuntu 14.10 x86-64. Thank you very much. Best regards. JBF Matúš Kukan committed a patch related to this issue. It has been pushed to "libreoffice-4-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ae9434662a9165aa31575448bc577e4b48db753&h=libreoffice-4-4-2 tdf#90010 Partially revert "package: Do not bother with deflating jpeg images" It will be available in 4.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This partial revert was in fact the right fix for this. I didn't realize that before. Anyhow, it's fixed now. Marking as such. comment #12 -> verified Best regards. JBF Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |