Summary: | FORMATTING Line spacing Proportional < 100% looks different in 4.3.4 than before | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED NOTABUG | ||
Severity: | normal | CC: | cno, gabsd84, kendy, michael.stahl, robinson.libreoffice, vsfoote |
Priority: | highest | Keywords: | bibisected, regression |
Version: | 4.3.4.1 release | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=53843 https://bugs.documentfoundation.org/show_bug.cgi?id=88670 https://bugs.documentfoundation.org/show_bug.cgi?id=79602 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Attachments: |
test file table paragraphs line spacing 95%
Bug 89788 Git Bisect Log |
Description
Cor Nouws
2015-03-02 21:45:04 UTC
Created attachment 113840 [details]
test file table paragraphs line spacing 95%
double checked with clean user profiles. OK in 4.3.3.2 / not OK in 4.3.4.1 > regression let's just set to new @Cor, Confirming. First incorrect appearance is with 4.3.4 @Kendy, would a piece to your broader line spacing UI work inserted in 4.3.4 maybe be the issue? http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-4&id=5929a87b8137bf6326adfd4ddfd8075e585ae15c Hmm, or guess maybe it could be related to Michael S. work for bug 79602 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-4&id=9605763e3dc8c85137787c77c31e8639553a35ed Wrt. comment 4 - I read this is an import problem, very unlikely to be related to the UI change... If you can bibisect this, that would be most appreciated! - thanks in advance :-) Setting priority to highest as this is a 4.3 MAB. This is part of an effort to make the importance of MAB reflected in priority too. Created attachment 113941 [details] Bug 89788 Git Bisect Log Hi I had a go at bisecting this bug. I have attached a copy of the log. I'm still pretty new to git bisect so hopefully I have done things correctly. Please let me know if I messed up the bisect in some way. Gabriel the problem was that before 4.3.4 the 95 % was actually rendered as 0.95 ^ 2 = 0.9025 = 90.25 %, and that was fixed by: commit 4e223fab04279c3583689e69fa1342966e81de36 Author: Michael Stahl <mstahl@redhat.com> AuthorDate: Wed Oct 29 23:50:21 2014 +0100 fdo#79602: sw: fix text formatting of proportional line space < 100% SwTxtFormatter::CalcRealHeight(): Apply the special treatment of < 100% line space shrinking the Height() of the line only to the first line in a paragraph; the subsequent ones are shrunk again (to the square of the desired proportion) 30 lines later. Also set the Ascent of the line, as the wrong base-line causes the lower part of the line to be clipped. so if it looks different it's not a bug but a feature :) (In reply to Michael Stahl from comment #9) > the problem was that before 4.3.4 the 95 % was actually rendered as 0.95 ^ 2 > = 0.9025 = 90.25 %, and that was fixed by: > ... > so if it looks different it's not a bug but a feature :) Thanks a lot for explaining. So this is in the category 'incompatible bug-fixes/improvements' .. > SwTxtFormatter::CalcRealHeight(): Apply the special treatment of < 100% > line space shrinking the Height() of the line only to the first line > in a paragraph; the subsequent ones are shrunk again (to the square of > the desired proportion) 30 lines later. If I understand the commit message well, the spacing gradually shrunk from value set to it's square 30 lines later..? If so, that would make an advise: was the spacing set to eg. 0.9 now make it 0.81 invalid too.. Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |