Summary: | Page counters in status bars are inconsistent: “Page N / N” vs. “Page N of N” | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Adolfo Jayme Barrientos <fitojb> |
Component: | UI | Assignee: | dobragab |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | ilmari.lauhakangas, robinson.libreoffice, samuel.mehrbrodt |
Priority: | low | Keywords: | difficultyInteresting, easyHack, skillCpp, topicUI |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:5.0.0 | ||
Crash report or crash signature: | Regression By: |
Description
Adolfo Jayme Barrientos
2015-02-25 08:27:18 UTC
Confirmed. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: ca7f62c8262662c8f58a3fa3b298623f25b55eaa TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-02-26_22:43:44 Locale: fi_FI Hello, I'd like to work on this bug from now, as a part of GSoC Easy Hacks. In case anyone knows in which file should I look for at Impress or Calc, it can save some time for me, because I am new to LibreOffice. dobragab dobragab, thanks a lot for having a look at this! Not being a *true* developer myself, I can refer you to bug 64290 comment 6, which dealt with a very, very similar enhancement. Please ask the developers list or the IRC channel if you get stuck. Thanks again! dobragab: For Calc, have a look at sc/source/ui/view/cellsh.cxx , search for STR_TABLE. You want to change the STR_TABLE in sc/source/ui/src/globstr.src to have a kind of "Sheet %1 of %2" and adapt the code in cellsh.cxx the same way as in http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4e4ccf8d571fd6f6ee538c4e406b07fc810e2d For Draw/Impress, you wrote me that you have some proof-of-concept patch, but that you have some issues with that - best if you can push the patch to gerrit, and we can sort out the missing pieces there as part of the review :-) Thanks for working on this! Submitted a patch: https://gerrit.libreoffice.org/#/c/14797/ Fixed in both Calc and Draw/Impress, text is also able to be localized. (Note: I changed some little code formatting at one point by accident.) Uploaded final patch. Successfully built, waiting for review. https://gerrit.libreoffice.org/#/c/14806/ Dobra Gabor committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4d000e85633c8e97e73bfc68a128dd7bea31223f tdf#89641 Page numbering in Calc and Draw/Impress It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you! Migrating Whiteboard tags to Keywords: (EasyHack TopicUi SkillCpp DifficultyInteresting ) [NinjaEdit] Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit] |