Summary: | EDITING: Insert Frame dialog shows empty lists for area fill types | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | tmacalp <tmacalp> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | caolan.mcnamara, cno, fdbugs, h3734236, paddy, sophi, vmiklos, vsfoote |
Priority: | medium | Keywords: | bibisected, bisected, needUITest, regression |
Version: | 4.4.0.3 release | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=80952 https://bugs.documentfoundation.org/show_bug.cgi?id=86578 https://bugs.documentfoundation.org/show_bug.cgi?id=90640 |
||
Whiteboard: | target:5.1.0 target:5.0.2 target:4.4.6 | ||
Crash report or crash signature: | Regression By: |
Description
tmacalp
2015-01-31 18:37:54 UTC
Reproducible with LO 4.4.0.3, Win 8.1. Not only Colour, but also Gradient, Hatching and Bitmap are empty. This appears to have been introduced with the below commit. (bisecting is complicated by related crashes and other regressions which have already been fixed, but this appears to be the source) Adding Cc: to vmiklos@collabora.co.uk; Could you possibly take a look at this? Thanks commit 6e61ecd09679a66060f932835622821d39e92f01 Author: Armin Le Grand <alg@apache.org> AuthorDate: Wed Mar 19 16:17:02 2014 +0000 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Fri Mar 28 14:31:08 2014 +0100 Merge back branch alg_writerframes to trunk (cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62) remains valid issue with current builds of master Version: 4.5.0.0.alpha0+ Build ID: 460b17d2712a80331a83329d2951f3e0303835cd TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-03-14_23:10:42 Locale: en_US I believe this also affects attempting to apply an image background to the frame upon creation. The dialog will show the image as a preview, but the newly created frame will have no background. 1. New document 2. Insert->Frame 3. Area tab 4. Fill Type -> Bitmap 5. Click "Import Graphic..." 6. Select an image and click OK 7. OK to create frame Expected: Frame should have a background image as its area. Actual: Frame has area set to "none." I performed this test in LO 4.4.2.2, but this bug also affects the master nightly as of 2015-03-31. Yes, the problem from command 0 is that the item set that would contain the color / gradient / etc types is filled when the dialog is created by the frame shell (used for existing frames), but not when created by the text shell (used for new frames). I'll take care of that. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c3ca675509101732d3d878d6ceb6226026cd9ac tdf#88986 sw: add missing XPropertyList pool items on TextFrame insertion It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c4e0aaa8d54877c55d3c4e397a7b869d8ff57cc tdf#88986 testcase It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #6) > Miklos Vajna committed a patch related to this issue. > It has been pushed to "master": > It will be available in 5.1.0. Thanks! Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a9218a741260d452106de1a4d5786c87499776d&h=libreoffice-5-0 tdf#88986 sw: add missing XPropertyList pool items on TextFrame insertion It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=55f0c2f416db716f0cccf1bb05625c264a78d9df&h=libreoffice-4-4 tdf#88986 sw: add missing XPropertyList pool items on TextFrame insertion It will be available in 4.4.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |