Summary: | Spacing to content should be disabled for images | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | cno, heiko.tietze, ilmari.lauhakangas, jluth, jmadero.dev, rb.henschel, thomas.lendo, vmiklos |
Priority: | medium | ||
Version: | 4.5.0.0.alpha0+ Master | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=90070 https://bugs.documentfoundation.org/show_bug.cgi?id=90805 https://bugs.documentfoundation.org/show_bug.cgi?id=122063 https://bugs.documentfoundation.org/show_bug.cgi?id=102011 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103270 |
Description
Yousuf Philips (jay) (retired)
2014-12-16 13:51:53 UTC
Unless UX disagrees - I'm setting this to WONTFIX. Sophi and I talked about it and we agree it's better as it is so you can actually see the border. This is just a difference of opinion that we'll endlessly go round and round arguing about. If UX team discusses and disagrees, please set to NEW. We had discussed this in one of the design/ux meetings and kendy stated that there is problems with default setting as it also alters the size of the image. I've filled the bug kendy observed in the design session in bug 90071, while this bug report will stick with spacing being set to 0 by default. In actuality, spacing to content should be disabled for images, as it is a feature of frames and not images. Seems bug 90071 was added as a duplicate of bug 90070 when i submitted it. Kendy asked me to CC you on this. :D So this spacing issue only occurs when you enable borders through the 'Borders' or 'Border Color' buttons in the frame toolbar (.uno:SetBorderStyle, .uno:FrameLineColor) and not when you set the line style in the 'Border Style' button (.uno:LineStyle). [spam link removed] An image is stored in a draw:image element, which is child of a draw:frame element. The draw:image element is the content of the draw:frame element. And a draw:frame element has a style of style family "graphic". Such styles have a style:graphic-properties element. And this allows fo:margin, fo:border and fo:padding, which correspond to the CSS box model. So even if you disable this feature in the UI, LO needs to be able to render ODF documents correctly, which uses padding in images. ODF follows the CSS-box model very close, but LO does not implement it correctly. (In reply to Regina Henschel from comment #8) > So even if you disable this feature in the UI, LO needs to be able to render > ODF documents correctly, which uses padding in images. The intend isnt to disable this feature, it is to set a better default value when borders are set. Yes, the default for padding should be 0cm. This issue might be obsolete. Newly inserted images have zero spacing in 6.1 (will be changed with bug 122063), and c6 clarifies this issue relates to borders Things like adding border colors / styles etc from the toolbar can also create default spacing. See Bug 90806 for example and code pointers. |