| Summary: | COLOR PICKER: Custom color picker doesn't allow selecting HSB | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Writer | Assignee: | Adolfo Jayme Barrientos <fitojb> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | barta, caolan.mcnamara, fitojb, quikee |
| Priority: | medium | Keywords: | regression |
| Version: | 4.4.0.0.alpha2 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.5.0 target:4.4.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 87064 | ||
| Attachments: |
screenshot
color picker from 4.3 |
||
|
Description
Yousuf Philips (jay) (retired)
2014-11-22 21:37:17 UTC
Yup I see the same.. This is a regression as it worked correctly in 4.3 daily. Version: 4.3.4.0.0+ Build ID: 81e4dbe1adf196ee20f1a4bfbc50b54abfc79f4b TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-4-3, Time: 2014-10-27_14:09:41 Created attachment 110533 [details] screenshot adding screenshot from 4.5.0.0.alpha0+ Build ID: 6b096f273ac9d7bbe93d2cb083958b3a04866d73 TinderBox: Win-x86@42, Branch:master, Time: 2014-12-04_22:57:23 Perhaps the fix is not complicated: both the RGB and HSB groups of radio buttons need to be in the same group. Created attachment 110617 [details] color picker from 4.3 (In reply to Adolfo Jayme from comment #4) > Perhaps the fix is not complicated: both the RGB and HSB groups of radio > buttons need to be in the same group. Yes i believe that must be the issue. I'm assuming this regression must have happened when the dialog was converted over to the new format. Adding Whiteboard:bibisectRequest - although as mentioned above it's pretty clear how this must have happened, identifying the exact commit may allow it to be passed to the original committer Submitted a fix in Gerrit: https://gerrit.libreoffice.org/13691 Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=12496548474d5361c034eba0ecb382a375b02769 fdo#86592 Fix radio button’s groups It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f693715fb18bae97b6285126923b78369a6b112d&h=libreoffice-4-4 fdo#86592 Fix radio button’s groups (4.4) It will be available in 4.4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |