Summary: | Segmentation fault when I press Ctrl-Z | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | TANAKA Hidemune <info> |
Component: | BASIC | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | fdbugs, lefevre00, robinson.libreoffice |
Priority: | highest | Keywords: | bisected, regression |
Version: | 4.4.0.0.beta1 | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=75757 | ||
Whiteboard: | target:4.5.0 target:4.4.0.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 79641 |
Description
TANAKA Hidemune
2014-11-22 02:48:01 UTC
I can reproduce that bug with Version: 4.4.0.0.beta1 Build ID: 9af3d21234aa89dac653c0bd76648188cdeb683e. But I can't see this issue with Version: 4.4.0.0.alpha1+ Build ID: b800d0b6ad74ce4a9adb23b865dd174d1eefa47b (latest of 44alpha2only bibisect repo). (In reply to TANAKA Hidemune from comment #0) > In the macro editor of Draw > Ctrl-A, Ctrl-X, Ctrl-Z > It was segmentation fault occurs After running the above. CONFIRMED with LO 4.4.0.0.beta1 + Ubuntu 14.04 Just 1) Open a new Draw document 2) Tools -> Macros -> Organize Macros -> LibreOffice Basic 3) Click 'Edit' button 4) Ctrl-A, Ctrl-X, Ctrl-Z And Boom! LibreOffice crashes. Status -> NEW I'll prioritize that as High/Critical, as it crashes consistently, but Macro editing isn't a very common activity for users. > But I can't see this issue with Version: 4.4.0.0.alpha1+ Build ID: > b800d0b6ad74ce4a9adb23b865dd174d1eefa47b (latest of 44alpha2only bibisect > repo). Hmm, so probably a regression. We'll be updating the bibisect repository to include the period from the alpha1 - beta1 very shortly. (In reply to Robinson Tryon (qubit) from comment #2) > > But I can't see this issue with Version: 4.4.0.0.alpha1+ Build ID: > > b800d0b6ad74ce4a9adb23b865dd174d1eefa47b (latest of 44alpha2only bibisect > > repo). > > Hmm, so probably a regression. We'll be updating the bibisect repository to > include the period from the alpha1 - beta1 very shortly. NOREPRO with 4.4.0.0.alpha2 + Ubuntu 14.04, so definitely a regression. (In reply to Robinson Tryon (qubit) from comment #2) > Just > 1) Open a new Draw document > 2) Tools -> Macros -> Organize Macros -> LibreOffice Basic > 3) Click 'Edit' button > 4) Ctrl-A, Ctrl-X, Ctrl-Z > > And Boom! LibreOffice crashes. Same crashing behavior when editing Macros in Writer (and probably other Components). (Use correct version in Version Field) Git bisect points at this commit: commit 63d8977f9fb0618d36dc8e0ee2f8068b1af92fe6 Author: Michaël Lefèvre <lefevre00@yahoo.fr> Date: Sat Nov 15 11:41:49 2014 +0100 fdo#75757 remove inheritance from std::vector For TextDoc, also removing ToolsList Also setting component to BASIC as this isn't related to drawing - the BASIC IDE behaves the same wherever it's opened from Michaël Lefèvre Could you please look into this regression? Thanks! (In reply to Luke from comment #7) > Michaël Lefèvre > Could you please look into this regression? Thanks! Yes I will, but not before december 20th. You could revert my commit if we need to fix it ASAP. It's just code cleaning, not really a feature. (This is an automated message.) Setting priority to highest as this is a MAB. This is part of an effort to make the importance of MAB reflected in priority too. it'll be this problem here TextNode* GetNode(sal_uInt16 pos) { return &maTextNodes[pos]; } where that returned Node belongs to maTextNodes and will be deleted along with it, but the undo code tries to get maTextNodes to *release* that node and pass ownership to it and will manage it itself, which can't work the way the code is right now. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=68d87e98951ae3ed5f7b863954667bfdd9805985 Resolves: fdo#86552 undo want to take ownership of nodes, but can't It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d584db0f8972fe7d4593b3f1538a967798e0f0d5&h=libreoffice-4-4 Resolves: fdo#86552 undo want to take ownership of nodes, but can't It will be available in 4.4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (regression) [NinjaEdit] |