Summary: | MENUS: Global shortcuts not appearing in menu entries | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | barta, heiko.tietze, mentoring, momonasmon, thomas.lendo, tim.lloyd |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillDesign, topicDesign |
Version: | Inherited From OOo | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=42003 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 85811 |
what Ctrl+W is supposed to do? I confess I don't know that shortcut. It closes the current document/window/tab. It is quite a universal shortcut key for most applications. good to know that. I've never noticed the existence of such a shortcut. Glad i could teach you something new. Why not give it a try so this can be set to NEW. :D I have been using Ctrl + W for some time now but never thought to look in the File Menu. Ctrl + Q is present. Close (which is essentially the same as Ctrl + W?) is present without the shortcut being shown. I don't see this as a bug as it is not interfering with operation but I would support it being a low priority enhancement Changing it to enhancement then. I am confirming it OK, so this is because there are two .uno: commands that do the same - .uno:CloseWin and .uno:CloseDoc. The .uno:CloseWin is in Window menu, and has the Ctrl+w visible there, .uno:CloseDoc has no shortcut assigned. But they do the same otherwise; so I guess we could change the description of '.uno:CloseWin' from 'Close Window' to just 'Close', and use it instead of '.uno:CloseDoc'. (In reply to Jan Holesovsky from comment #8) > OK, so this is because there are two .uno: commands that do the same - > .uno:CloseWin and .uno:CloseDoc. The .uno:CloseWin is in Window menu, and > has the Ctrl+w visible there, .uno:CloseDoc has no shortcut assigned. Well i guess the best choice is to give .uno:CloseDoc the shortcut, as many people see the File menu and less people see the Window menu. > But they do the same otherwise; so I guess we could change the description > of '.uno:CloseWin' from 'Close Window' to just 'Close', and use it instead > of '.uno:CloseDoc'. Well 'Close Window' is under the Window menu and it would look strange having it as 'Close' when the menu has 'New Window'. This seems to lack a final consensus. Could be turned to easy hack. I would solve the example with CloseDoc but the summary talks about global shortcuts in general. And we have a lot hard-coded, see https://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/edtwin.cxx?r=1675f5c0#1351 Hence, we could also resolve as WF. Can't the hardcoded ones not be shown in the UI automatically? Or do I get something wrong here. I wouldn't close it as WF. Everything is possible, is just zeros and ones. Point is that a function checks whether alt (or command) is pressed together with F4 (or Q) and terminates the application. There is no other place where alt+F4 is stored and can be used in the menus. Of course, hard-coding twice is possible. (The example is obviously just this, Exit is a UNO command with a dedicated shortcut.) We discussed the topic in the design meeting and decided to use CloseDoc for ctrl/cmd+W. This command is what is shown in the main menu under File > Close. W_MOD1 is assigned to .uno:CloseWin in /officecfg/registry/data/org/openoffice/Office/Accelerators.xcu and should become .uno:CloseDoc which is set to F4_MOD1. So maybe we exchange the commands - or alternatively use CloseWin in the menu. Unlike what was stated in the comments here, .uno:CloseWin and .uno:CloseDoc are *not* the same. .uno:CloseWin (as present under the Window menu) is for closing just the current window, while .uno:CloseDoc is for closing all windows of the current document (it's possible to open several windows for the same document via Window > New Window menu). MS Word has the same behavior for Ctrl+W, for closing just the current window, and not the document entirely. |
Ctrl + W is set as a globally shortcut key, but not set on a per module bases, so the shortcut key is not shown in the File menu of each module. Attachment 109001 [details] shows the File menu in writer.