Bug 83192

Summary: By the operation after moving the cell which inserted the comment Calc crashed. (REDO move cell with comment CRASH)
Product: LibreOffice Reporter: LibreFun <odonshigeru>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: critical CC: fdbugs, lgodard.libre, raal, timur
Priority: high Keywords: bibisected, bisected, haveBacktrace, regression
Version: 3.6.5.2 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=90741
https://bugs.documentfoundation.org/show_bug.cgi?id=91995
https://bugs.documentfoundation.org/show_bug.cgi?id=92995
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: gdb log

Description LibreFun 2014-08-28 13:04:10 UTC 
Steps:
1.  Make Calc Spreadsheet.
2.  Insert comment into A1 cell. 
3.  Click A1 cell  while pushing the 「Shift」 button.  
4.  Drag and Drop to A2. 
5.  Drag and Drop to A3 Again. 
6.  Push Ctrl-Z (Undoing) Twice.
7.  Push Ctrl-Y (Redo) Twice. 

Observed: Crashes

Expected: Not to Crash
Comment 1 raal 2014-09-13 14:39:22 UTC 
I can reproduce with LO 4.2.6, Linux
I can reproduce with  Version: 4.4.0.0.alpha0+
Build ID: e2723d00b77dc1044e2ba599ba93517af34e1ea5
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-09-09_23:17:41
Comment 2 raal 2014-09-13 14:40:18 UTC 
Created attachment 106213 [details]
gdb log
Comment 3 Matthew Francis 2015-03-31 08:37:03 UTC 
*** Bug 88184 has been marked as a duplicate of this bug. ***
Comment 4 Matthew Francis 2015-03-31 08:42:50 UTC 
This was at least made worse by the below commit. After this, a crash reliably occurs for me at the first undo in step 6 of comment 0.

commit c0deb50f8f7feecb7adb049e8253c9566232abde
Author: Kohei Yoshida <kohei.yoshida@collabora.com>
Date:   Mon Jan 27 14:26:23 2014 -0500

    Handle note instances during copy-n-pasting of single cell.
    
    Change-Id: Ib258556414fd94b5156b65777478a8fd37abfd9e
Comment 5 Timur 2015-04-03 15:53:12 UTC 
This seems like started somewhere in 3.6.5.x.
More simple steps to reproduce:
1.  Open Calc Spreadsheet.
2.  Insert comment into A1 cell. 
3.  Click A1 cell while pushing the 「Shift」 button.  
4.  Drag and Drop to A2. 
5.  Push Ctrl-Z (Undo).
6.  Push Ctrl-Y (Redo). - CRASH
Comment 6 Timur 2015-09-30 10:04:33 UTC 
I'd say High-Critical per https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg.
Comment 7 Robinson Tryon (qubit) 2015-12-13 11:10:54 UTC 
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]
Comment 8 Timur 2016-03-23 16:42:20 UTC 
Looks like it was fixed in 4.4.6, so I'll close.
Feel free to reopen if tested otherwise.