Summary: | [EasyHack] extend lint-ui.py to check for UI title labels | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Thomas Arnhold <thomas-libo> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | caolan.mcnamara, h3734236, jorendc, robinson.libreoffice |
Priority: | medium | Keywords: | needsDevEval |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=76203 | ||
Whiteboard: | target:5.1.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 143781 | ||
Attachments: | Python script to check title cases |
Description
Thomas Arnhold
2014-06-23 10:48:47 UTC
I did write a python script to check for titles. I'm currently working to check normal labels too (not only title labels). I'll attach the script used to this bug report. Afterwards I'll have a look at this lint-ui.py to implement it over there. Kind regards, Joren Created attachment 101573 [details]
Python script to check title cases
Still some manual work/review to do. It only splits words by space. Words surrounded by brackets or with other punctuation marks will need different approach.
Kind regards,
Joren
Ah, great! So I'll assign you to this bug. Hello! I'm starting work on this bug. Rosemary committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b4a224d1a91232a16b70be4531a3e6fd2d9bc9ae tdf#80387 Extended lint-ui.py to check for UI title labels It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Here are the GNOME casing rules https://developer.gnome.org/hig-book/3.2/design-text-labels.html.en#layout-capitalization I think rosemarys child[@type='label'] currently captures the "Group box or frame labels" category. And some of those categories we don't use. But we do have Button Labels, Menu Items, and Title bar labels which remain un-checked outside of that pattern I believe. Migrating Whiteboard tags to Keywords: (needsDevEval) [NinjaEdit] |