Summary: | Menus are getting invisible when hovering | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Florian Reisinger <reisi007> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | caolan.mcnamara, chris.sherlock79, courrier.oou.fr.mjk, f.alexander.wilms, jmadero.dev, miguelangelrv, serval2412 |
Priority: | highest | Keywords: | regression |
Version: | 4.3.0.0.alpha0+ Master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=77934 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 75025 | ||
Attachments: | Showing the error in a 4.3 alpha1+ master |
Description
Florian Reisinger
2014-04-25 06:45:56 UTC
This is not just a 64 bit windows bug. After I did a "git reset --hard origin/master" the menu's were all blank, except when the mouse is hovering over an item. $ lsb_release -rcd ; uname -rm Description: Linux Mint 16 Petra Release: 16 Codename: petra 3.11.0-12-generic i686 As a temp workaround, you can do a: $ SAL_USE_VCLPLUGIN=gen ./soffice *** Bug 77933 has been marked as a duplicate of this bug. *** On pc Debian x86-64 with master sources updated today, I can reproduce this. When just hovering menus without try to select an entry it's ok, but when you hover inside any menu, only the current entry of the menu displays. It's not a crash but it's a big regression of a core basic feature used a lot by a lot of people, IMHO it's a blocker. Chris/Caolán: one for you? (vcl part I suppose) When I gave a try to fdo#77934, I saw that the bug was also present in context menus (which appears with right click) *** Bug 77956 has been marked as a duplicate of this bug. *** I think this commit 0ef2999f7b498686ad38749b93f0591dd52bcc50 solved the problem. At least, it's ok right now after having updated local master sources. Florian/Joren/Luke: Could you give a try with master sources updated after this commit? Just checked and it is resolved! Thanks :) *** Bug 77983 has been marked as a duplicate of this bug. *** Caolan's commit message explains what happened here: given the explanation of MenuFloatingWindow::InitClipRegion() it should not be virtual then prior to 95711f5b9e7b6a982d1762d37d5a38e0f40b86f9 the menu ImplInitClipRegion had nothing to do with the outdev ImplInitClipRegion and so all the original ImplInitClipRegion calls here should now be routed to InitMenuClipRegion which was removed by "In fact InitMenuClipRegion() is unused" so restore that. http://cgit.freedesktop.org/libreoffice/core/commit/vcl?id=39a060442cb1148e976c4f2316d0449dd285e8df In other words, Windows derives from OutputDevice and this had a virtual function IntiClipRegion. However, MenuFloatingWindow derives indirectly from Window, but it used the function InitClipRegion for an entirely different purpose. When it was made virtual, it caused this issue. Verified using windows 8.1 using Version: 4.3.0.0.alpha1+ Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36 Kind regards, Joren |