Summary: | Other: crash when undo 'delete row above' with comments in rows below | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | A (Andy) <stgohi-lobugs> |
Component: | Calc | Assignee: | Kohei Yoshida <kohei> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | jbfaure, jorendc, miguelangelrv |
Priority: | medium | Keywords: | regression |
Version: | 4.2.0.4 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | BSA target:4.3.0 target:4.2.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 65675 |
Description
A (Andy)
2014-02-15 19:12:57 UTC
One more issue which is from my point of view related to this bug and that's why I have not opened a new bug report. Steps to Reproduce: 1. Open a new spreadsheet in CALC 2. Type in cell B3 = "1" and in cell B4 = "2" 3. Go to cell B3 and insert a comment = "C1" and then go to cell B4 and insert a comment = "C2" 4. Select the second row (on the row name "2" on the left) and make a right mouse click and select DELETE SELECTED ROWS to delete the row Result: The comments are moved up one more row, resulting in the deletion of the comment "C1" 5. Press the keys CTRL + Z two times Result: LO crashes with the error message: Runtime Error (R6025 - pure virtual function call) Due to this crash I marked this bug as critical. Thanks for reporting. Tested using Mac OSX 10.9 with LibreOffice 4.2.1.1. I fail to reproduce your testcase in the Description. So this is probably already fixed. (might be related to bug 74273) I CAN reproduce your testcase in Comment 1. LibreOffice already crashes when hitting undo (cmd+z here on mac) for the first time. I get exactly the same result as jorendc with Version: 4.2.1.1 Build ID: d7dbbd7842e6a58b0f521599204e827654e1fb8b on Linux X64 DEB: - testcase in description is resolved - testcase in comment #1 : I get also the crash from the first undo (using CTRL - Z) The same results: Win7x64Ultimate. Version: 4.2.1.1 Build ID: d7dbbd7842e6a58b0f521599204e827654e1fb8b - Description seems resolved. - Comment #1, crash with the first Ctrl+Z maybe related also to: https://bugs.freedesktop.org/show_bug.cgi?id=72293 I'm on it. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a5df6427913af1df99e770ea68daaeeeea02e7c fdo#75032: Add a test case to reproduce the crash. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e49b6abe7cedd2ac7137170f76ec5d7e14bd295 fdo#75032: Skip notes when copying values from undo document. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Backport requests: 4.2: https://gerrit.libreoffice.org/8089 4.2.1: https://gerrit.libreoffice.org/8090 That fix has a problem. I need to revise it. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=93d2cd25597c519029ec12bbaefd6c518890beed fdo#75032: Extend the test to catch another use case. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=575e88da278f536ebfb6562dfd98f341240afec4 fdo#75032: Handle note copying correctly. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f0b4fe210200a3620cf05f30242771b01d991658&h=libreoffice-4-2 fdo#75032: Handle note copying correctly. It will be available in LibreOffice 4.2.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed. (In reply to comment #13) > Fixed. Thank you very much Kohei! Verified fixed on version 4.2.3.0.0+ under Ubuntu 13.10 x86-64. Best regards. JBF Thanks Kohei. Verified in: Version: 4.2.3.0.0+ Build ID: 7af1124f83df4d96f6ebe58536de7c51406df661 TinderBox: Win-x86@42, Branch:libreoffice-4-2, Time: 2014-02-20_11:39:39 Version: 4.3.0.0.alpha0+ Build ID: 22b709e84a7b6d38cab2dd37f2f2b28e0fc9d062 TinderBox: Win-x86@39, Branch:master, Time: 2014-02-20_00:01:31 Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e285e059b6a03b426a0f64ff3686966802d040c3&h=libreoffice-4-2-2 fdo#75032: Handle note copying correctly. It will be available already in LibreOffice 4.2.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |