Summary: | Document comparison causes assertion failure in SwpHintsArray::Check | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jan Holesovsky <kendy> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bfo.bugmail, jorendc, michael.stahl, serval2412, sophi |
Priority: | highest | Keywords: | regression |
Version: | 4.1.0.4 release | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=83655 | ||
Whiteboard: | target:4.3.0 target:4.2.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 65675 | ||
Attachments: |
Base document.
Document to compare (to be loaded via Edit -> Compare Documents). bt with symbols |
Description
Jan Holesovsky
2014-02-10 13:09:23 UTC
Created attachment 93770 [details]
Base document.
Created attachment 93771 [details]
Document to compare (to be loaded via Edit -> Compare Documents).
Not sure what's the impact; but I guess this might be a mab. Hi Kendy, just for information, I do not reproduce with Version: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 on Ubuntu 13.10 x64. I can compare the two documents, accept or reject your modification, no loop for me - Sophie (In reply to comment #4) > Hi Kendy, just for information, I do not reproduce with Version: 4.2.0.4 > Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 on Ubuntu 13.10 x64. I > can compare the two documents, accept or reject your modification, no loop > for me - Sophie Looks like a debug-build only bug. This because of the assertion that is raised. /me currently doesn't have a debugbuild. @Kendy: can you confirm this is debug-only :)? Kind regards, Joren No problem (accepting, rejecting is ok) with Version: 4.2.1.1 Build ID: d7dbbd7842e6a58b0f521599204e827654e1fb8b on Linux X64 DEB. Perhaps this bug could be dedicated to debugbuild. And so this bug shouldn't stay in MAB ? Checked with: Version: 4.2.1.1 Build ID: d7dbbd7842e6a58b0f521599204e827654e1fb8b Windows 8.1 Enterprise 64 bit Could not reproduce. No crash. Created attachment 95240 [details]
bt with symbols
On pc Debian x86-64 with master sources updated today, I could reproduce the crash.
Indeed, I've got this on my autogen.input:
--enable-debug
--enable-dbgutil
I attached the bt which is very similar.
@Kendy, Julien: not sure this assert does affect/warn for a bug which can cause information loss/high risk for crashers/regression... If not, you agree to remove this from the mab4.2 list? Jorendc: I just wanted to confirm the bug. For the rest, I don't know and I'll let Jan speak :-) Fix priority for MABs. obviously regression from 6db39dbd7378351f6476f6db25eb7110c9cfb291 the document compare is a bit of a special case because the document is loaded but has no layout, so these asserts don't really matter... fixed on master (why is an assertion-only/debug-only bug a MAB?) Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=80b131038d2375c9855ee5fbe225e75bdad2645e fdo#74790: sw: Compare Document: fix assertions about RSID-only hints The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to comment #12) > (why is an assertion-only/debug-only bug a MAB?) Because a well-known developer did mark as such :-). I, and other QA-ers, are not eager to overrule such decision :-). Glad it is fixed though! Thanks Michael! Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8fb7fa143cca628654933459135eee6c3f1450d4&h=libreoffice-4-2 fdo#74790: sw: Compare Document: fix assertions about RSID-only hints It will be available in LibreOffice 4.2.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |