Summary: | FILEOPEN: DOCX: Figures with text which are on canvas become rectangles | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Alexandr <alexpikptz> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | barta, vmiklos |
Priority: | medium | Keywords: | regression |
Version: | 4.3.0.0.alpha0+ Master | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=74397 https://bugs.freedesktop.org/show_bug.cgi?id=70942 https://bugs.freedesktop.org/show_bug.cgi?id=84399 |
||
Whiteboard: | target:4.3.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 75025 | ||
Attachments: |
A screenshot with LO 4.3.0 19dec2013
A screenshot with LO 4.3.0 18jan2014 screenshot 4.2 vs 4.3 screenshot from Word 2007 of test document previously shown in LO 4.2.0.4 and master |
Description
Alexandr
2014-02-02 18:05:17 UTC
Created attachment 93243 [details]
A screenshot with LO 4.3.0 18jan2014
Mmh, looks very related to bug 70942... looks like there was a patch committed on 13 January 2014. Kind regards, Joren Thank you, Jorendc, for noticing me the bug 70942. That bug is about shapes without canvas, so another my report (bug 74397) is a duplicate. It seems I should improve my searching skills. (In reply to comment #0) > ... > > This bugreport is about the case WITH canvas. > > How to reproduce: > 1. Create new document in MS Word 2010 (I don't try other versions) > .... please attach a test case for those who don't have MS Word 2010 Tommy, the test document is attachment 93238 [details] for bug 74397. Top line of figures in this document is on canvas. Created attachment 94155 [details] screenshot 4.2 vs 4.3 (In reply to comment #5) > Tommy, the test document is attachment 93238 [details] for bug 74397. Top > line of figures in this document is on canvas. confirmed. that is nasty. I add a comparative screenshot between 4.2 and 4.3 Created attachment 96009 [details] screenshot from Word 2007 of test document previously shown in LO 4.2.0.4 and master A screenshot from Word 2007 of the https://bugs.freedesktop.org/attachment.cgi?id=93238 test document. Notice that even 4.2.x OOXML import is mishandling the shapes. This is a regression from 75934fc178ed90b56d77eb1efebed5bdac8427b6: Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Fri Jan 17 17:25:08 2014 +0100 VML import: handle shape with text inside groupshape as TextShape This matches the behavior of the WW8 import and gives us the required text wrapping when the shape text doesn't fit in a single line. Change-Id: I32a13516503620344d313593834be29a3dc9f726 I'll take care of this. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=81f9fe3a14f0fc99afbfa7ce3a26a9c7855d0919 fdo#74401 VML groupshape import: only handle v:rect as TextShape The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Regression was master-only, no backport. Hello. The bug is not reproducible with LibreOffice Writer 4.3.0.0.alpha0+ Build ID: 926435ef5ab26e647c09887d471bde25b24e1c16 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-03-22_00:09:10 Miklos, could you also handle rounded rectangles as textshapes? They were not affected by this bug (see shape 2 “Smooth angle rectangle” in the screenshots) |