Summary: | FILEOPEN: Draw 4.2 corrupts figures combined in previous version | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Alexandr <alexpikptz> |
Component: | Draw | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | alexpikptz, caolan.mcnamara, cno, dtardon, iplaw67, jbfaure, michael.stahl, rb.henschel, surbun |
Priority: | highest | Keywords: | regression |
Version: | 4.2.0.0.alpha1 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=73204 https://bugs.freedesktop.org/show_bug.cgi?id=74109 |
||
Whiteboard: | BSA odf target:4.3.0 target:4.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 65675 | ||
Attachments: |
A test file with combined lines
A screenshot with LO 4.1 A screenshot with LO 4.2.0.1 three combinations of two objects - as in 4.1.4.2 and with screenshot |
Description
Alexandr
2014-01-07 11:24:26 UTC
Created attachment 91595 [details]
A screenshot with LO 4.1
Created attachment 91596 [details]
A screenshot with LO 4.2.0.1
thanks Alexandr. > New, Regression, major I'll attach another sample file Created attachment 91597 [details]
three combinations of two objects - as in 4.1.4.2 and with screenshot
problem already exists in 4.2.0 alpha1 The problem is, that LO4.1 uses a special handling of combined shapes which is different from LO4.2 and different from older versions. You need to open the file in LO4.1, then goto Tools > Options > Load/Save > General and chose the ODF format version "1.2 Extenden (compat)". Then re-save the document. After that it should be correct in LO4.2. The problem is not LO4.2 but the handling in LO4.1. Is there another behavior besides the handling of closed paths, that are affected by save in "1.2 Extended (compat)" mode? If not, I suggest, to change 4.1 to use save in "1.2 Extended (compat)" mode as default with the next update. That way the amount of such documents can be reduced. In addition, there should be a notice on the 4.2 release notes to correct the documents before changing to version 4.2. I change platform to all, because it is not a Linux specific problem. I can not reproduce the problem with saving in “1.2 Extended (compat)” mode. But due to a warning in “Options” dialogue it “may cause information to be lost”. A notice in ReliaseNotes should be, but most of users does not read it. Also it makes some users downgrade LibreOffice when they meet such documents. That's why I think saving in compatible mode is a workaround only, not a fix. (This is an automated message.) Setting priority to highest as this is a 4.2 MAB. This is part of an effort to make the importance of MAB reflected in priority too. a6d89e17995987549db36695f3ea490a18f30ba4..40543e5321c8f618c125fd6f7f9a24b87431277a these 2 commits introduce the regression: commit e44335abe006d05f0f915279605a03ef084116d6 Author: Caolán McNamara <caolanm@redhat.com> AuthorDate: Thu Oct 31 15:51:30 2013 +0000 Related #i123433# PolyPolygonBezier must be drawing::PolyPolygonBezierCoords Change-Id: Idc7e0a2651f2e0b499bbf8b8443ffb84b54a45b6 commit 223f6b631c1b087754c0f9051fb55f029f2503ce Author: Armin Le Grand <alg@apache.org> AuthorDate: Tue Oct 29 14:11:45 2013 +0000 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Thu Oct 31 15:56:14 2013 +0000 Resolves: #i123433# Detect pseudo-vertices at svg import... unify svg:d handling, correct svg:d import for relative sub-polygons in svg import; changed default for moveto writes for svg:d in ODF to absolute *** Bug 73814 has been marked as a duplicate of this bug. *** (In reply to comment #6) > The problem is, that LO4.1 uses a special handling of combined shapes which > is different from LO4.2 and different from older versions. You need to open > the file in LO4.1, then goto Tools > Options > Load/Save > General and chose > the ODF format version "1.2 Extenden (compat)". Then re-save the document. > After that it should be correct in LO4.2. > > The problem is not LO4.2 but the handling in LO4.1. loading the attachments in older versions shows that 3.5.0.3 up to 4.1.x display the bugdocs in the same way, and the 4.2 regression looks similar to the display in 3.4.6 and 3.3.4. in any case 4.2 must be able to display documents stored by all older versions the same way. need to reconcile with bug 47406 and a2ee8055e9c136923f0244fe289cac6377933c31 and 7a19798c73fd39d8d69ff6364f0696e68cdd1381 methinks Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b663316e83ec6b19b8fc33ade38086b22ab04b67 Resolves: fdo#73355 reconcile legacy path bug detection The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-2-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b09fae12aaae3519559a1915d258525b5fbcfbca&h=libreoffice-4-2-0 Resolves: fdo#73355 reconcile legacy path bug detection It will be available already in LibreOffice 4.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I guess its unclear if there will be a rc4, but if there is we should be covered. Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4479507f744149e8268be48de6d600e7ccefd0dd&h=libreoffice-4-2 Resolves: fdo#73355 reconcile legacy path bug detection It will be available in LibreOffice 4.2.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 73204 has been marked as a duplicate of this bug. *** *** Bug 73204 has been marked as a duplicate of this bug. *** Caolán McNamara, thank you. I tested combined figures in odt, odg (Draw), odg (Impress), odp, ods, otp, ots files saved in LibreOffice 4.1.4.2 with 1.2 extended (recommended) ODF format. LibreOffice 4.3.0.0.alpha0+ Build ID: ecf617ee0cb74526e3989500c122835c32082845 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-01-25_00:16:16 opens them without problems. *** Bug 74109 has been marked as a duplicate of this bug. *** (In reply to comment #21) > *** Bug 74109 has been marked as a duplicate of this bug. *** I think that bug 74109 is not a duplicate of this one (see https://bugs.freedesktop.org/show_bug.cgi?id=74109#c3) but maybe they are linked. The fix for this one does not solve the problem described in bug 74109. Best regards. JBF |