Summary: | significant custom shape import regression ... | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Michael Meeks <michael.meeks> |
Component: | Draw | Assignee: | Muthu <muthu.subramanian.karunanidhi> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | idler.1st, rb.henschel |
Priority: | medium | Keywords: | regression |
Version: | 4.2.0.0.alpha0+ Master | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=122325 https://bugs.documentfoundation.org/show_bug.cgi?id=76334 https://bugs.documentfoundation.org/show_bug.cgi?id=112192 |
||
Whiteboard: | target:4.3.0 target:4.2.0.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 65675 | ||
Attachments: |
custom shapes ... much too small ...
Comparison; 4.3.0.0 left, 4.1.4.2 right 4.2.0.1+(bad) v.s. 4.3.0.0+(nice) |
Description
Michael Meeks
2013-12-23 21:34:48 UTC
Created attachment 91162 [details]
custom shapes ... much too small ...
Muthu Subramanian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=beba4603ee8e603fff2599bee7f157d90872cb99 fdo#72998: Custom shapes have improper size. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 91261 [details] Comparison; 4.3.0.0 left, 4.1.4.2 right Looks fixed to me. Read: shapes are imported correctly. See attached screenshot: LEFT: Version: 4.3.0.0.alpha0+ Build ID: 5be7ec4193b892e5643ff5f3f2e6755319569190 TinderBox: Win-x86@39, Branch:master, Time: 2013-12-27_23:55:02 RIGHT: Version: 4.1.4.2 Build ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72 The borders of the shapes in 4.3.0.0 looks tinner/less clear then those in 4.1.4.2. Not sure what's the correct behavior :) Kind regards and best wishes! Joren The lines seem to be the right size in the current version (i.e. thinner) - these seem to be the same way MSO loads them. Muthu Subramanian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee6eadfc617a1ce3bc2b489523ac713b99482404 fdo#72998: Add unit test case. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Resolving this fixed. Created attachment 91391 [details] 4.2.0.1+(bad) v.s. 4.3.0.0+(nice) The patch works well in The LibreOfficeDev-4.3.0.0.alpha0+: Build ID: b178afc88ba97f04036e6eef9cf1ee0da987b258 TinderBox: Win-x86@39, Branch:master, Time: 2014-01-01_05:35:23 But there are no fixed in The LibreOfficeDev-4.2.0.1.0+: Build ID: 74fcb90dc73e235934fc19d39b7d7b0bf07cc8a5 TinderBox: Win-x86@42, Branch:libreoffice-4-2, Time: 2014-01-01_12:50:48 This bug reopened because of it. Muthu Subramanian committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bec40dcd4f36bf774f6bc2d805a646ba2232175c&h=libreoffice-4-2 fdo#72998: Custom shapes have improper size. It will be available in LibreOffice 4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |