Summary: | Chart: Label on X axis are lost when copying from Calc to Writer, Impress and Draw | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | sophie <sophi> |
Component: | Chart | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andis.lazdins, barta, bugzilla.lenochod, jalojo, lionel, markus.mohrhard, michael.stahl, timar74 |
Priority: | medium | Keywords: | regression |
Version: | 4.2.0.0.beta2 | ||
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=61805 https://bugs.freedesktop.org/show_bug.cgi?id=68663 https://bugs.freedesktop.org/show_bug.cgi?id=87012 |
||
Whiteboard: | target:4.4.0 target:4.3.0.1 target:4.2.6 target:7.2.0 | ||
Crash report or crash signature: | Regression By: |
Description
sophie
2013-12-15 09:52:35 UTC
Hello Sophie, The same on Windows 7 Home Premium. x labels are missing on Chart after copy. Kind regards, Jacques *** Bug 73931 has been marked as a duplicate of this bug. *** works fine with 4.1.4.2 --> regression issue not limited to Writer. same bug when you paste to Impress and Draw as well. edited summary notes b090cbdf82e0827234caf5969124f6631311ef35 is the first bad commit commit b090cbdf82e0827234caf5969124f6631311ef35 Author: Lionel Elie Mamane <lionel@mamane.lu> Date: Fri Aug 30 18:00:21 2013 +0200 fdo#68663 don't blindly force categories when there are none As a point of additional data, this commit was discussed in thread starting at http://lists.freedesktop.org/archives/libreoffice/2013-August/055558.html (In reply to comment #6) > As a point of additional data, this commit was discussed in thread starting > at > http://lists.freedesktop.org/archives/libreoffice/2013-August/055558.html I'm not happy with the commit. It clearly breaks copy&paste and categories are not necessarily written out. I would vote to revert the patch and look for a proper fix without breaking chart2 in all other applications. (In reply to comment #7) > (In reply to comment #6) > > As a point of additional data, this commit was discussed in thread starting > > at > > http://lists.freedesktop.org/archives/libreoffice/2013-August/055558.html > > I'm not happy with the commit. It clearly breaks copy&paste and categories > are not necessarily written out. I would vote to revert the patch and look > for a proper fix without breaking chart2 in all other applications. Who understands the principles of the charts code? When should categories be present and when not, and whose responsibility is it to add them / how can an application signal to the chart code it does not want categories? (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > As a point of additional data, this commit was discussed in thread starting > > > at > > > http://lists.freedesktop.org/archives/libreoffice/2013-August/055558.html > > > > I'm not happy with the commit. It clearly breaks copy&paste and categories > > are not necessarily written out. I would vote to revert the patch and look > > for a proper fix without breaking chart2 in all other applications. > > Who understands the principles of the charts code? When should categories be > present and when not, and whose responsibility is it to add them / how can > an application signal to the chart code it does not want categories? I think currently I'm the one knowing most about the chart code. I would need to explore why base is behaving different than calc, writer, impress but an initial look at the file shows that the data table has a slightly different form. I still think we should revert this patch as it breaks copying charts and it is a regression. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=91ca3a92c54a08ad13497d7e8ac1916e7b68bbfd fdo#72727: Revert "fdo#68663 don't blindly force categories when there are none" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f025f22e8dfd7fe03527604e0edee8a8a818cca&h=libreoffice-4-3 fdo#72727: Revert "fdo#68663 don't blindly force categories when there are none" It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. 4.2 backport: https://gerrit.libreoffice.org/9658 (In reply to comment #9) > I still think we should revert this patch as it breaks copying charts and it > is a regression. Since nothing is happening, and the chart breakage is significant, I took this advice and reverted it. Sorry. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=61d958f37ed2aad6be2eab7bb507e0fb77716eec fdo#72727: Revert "-Werror=unused-but-set-variable second try" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=84c8157b46e5b2feff48f8a9e8d5df2879c5a740&h=libreoffice-4-3 fdo#72727: Revert "-Werror=unused-but-set-variable second try" It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a53dfa86a2b61154f4c2c7cb356d32a569aaf69&h=libreoffice-4-2 fdo#72727: Revert "fdo#68663 don't blindly force categories when there are" It will be available in LibreOffice 4.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b959fb871a68f08a06850909abd16f71033aa3a&h=libreoffice-4-2 fdo#72727: Revert "-Werror=unused-but-set-variable second try" It will be available in LibreOffice 4.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14c86d402243c0d2730ff38a1b8ac1a4456974de tdf#72727: sw_layoutwriter: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |