Summary: | Wrong tips for functions in Calc that have a funcname_ADD or funcname.* variant too | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Kü <kuehl> |
Component: | Calc | Assignee: | Winfried Donkers <winfrieddonkers> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | f.rr, jbfaure, kuehl, winfrieddonkers |
Priority: | medium | ||
Version: | 4.1.1.2 release | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=75264 | ||
Whiteboard: | target:4.3.0 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
example screenshot for GDC function
Function with incorrect help tip. |
Reproduced with LibO 4.1.2.3 on Win7 Reproducible with LO 4.1.4.0.0+ and master under Ubuntu 13.10 x86-64 Best regards. JBF *** Bug 74025 has been marked as a duplicate of this bug. *** See bibisect in https://bugs.freedesktop.org/show_bug.cgi?id=74025#c3 Best regards. JBF Created attachment 92813 [details]
Function with incorrect help tip.
I think this bug must have high importance. In italian language cause incorrect help tip in 56 functions, including the most-used like IF, SUM, DATA, MAX, YEAR etc. I atttached the list. Change in to italian language and you can test. New users with low knowledgecan can be discuraget to use LibreOffice. Thenk you. I will take this bug. Found the cause; think I fixed it too, but want to test some more. (for ease of reading I use GCD() and GCD_ADD() as an example:) Explanation: In the alphabetic functiondescription list, GCD_ADD(..) comes before GCD(..). The function description is found by searching for the function name ( where the description will be longer than the function name as it has the arguments added to it). And so GCD_ADD is found first... Solution: search for "GCD(" instead of "GCD". Also, I found that when typing in a cell ("=G", "=GC", "=GCD") a tip appears for the expected function, but this tip disappears as soon as you get to "=GCD_". As this is related code, I want to have a look at that too, before I submit my patch. I have created a separate bug report for the second problem as described in comment #8 : bug 75264. Winfried Donkers committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=00856ac90d4a230d6f219937f836ca0e9f3fe1e3 fdo#71077 wrong tips for some calc functions The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I tested the 'master' vertion and the bug looks fixed. I discovered an other bug and I think in the same code. The functions that finish with a number are no showed. To riproduce it... Type =DAYS360( in a cell it doesn't sho nothing. I don't know if is better to create a new bug or not. (In reply to comment #11) > I discovered an other bug and I think in the same code. > The functions that finish with a number are no showed. > > To riproduce it... > > Type =DAYS360( in a cell > > it doesn't sho nothing. > > I don't know if is better to create a new bug or not. Bug 75264 is for this problem (although the bug title is not yet satisfactory). I set this bug to closed as the fix has been pushed and confirmed. (In reply to comment #12) > (In reply to comment #11) > > I discovered an other bug and I think in the same code. > > The functions that finish with a number are no showed. > > > > To riproduce it... > > > > Type =DAYS360( in a cell > > > > it doesn't sho nothing. > > > > I don't know if is better to create a new bug or not. > > Bug 75264 is for this problem (although the bug title is not yet > satisfactory). > > I set this bug to closed as the fix has been pushed and confirmed. I'm sorry, I didn't understand, the problem is not the bug title but my bad english. Then you for fixed the bug. (In reply to comment #13) > I'm sorry, I didn't understand, the problem is not the bug title but my bad > english. That's no problem, just as you I am not a native English speaker. I also have my difficulties in either being clear myself or understanding others ;) It's because of everybody's feedback and help that LibreOffice keeps improving! |
Created attachment 88397 [details] example screenshot for GDC function When you enter a function in Calc you get a tip in a yellow box with help for the entered function. This help tip is incorrect for functions that have a *_ADD variant too. For this functions you see the help tip for the *_ADD function instead of the correct help tip for the function whithout *_ADD. I added a screenshot with the wrong behavior of the GCD function. This behavior is present in 4.1 as well as in 4.0 but not present in 3.6 release.