Summary: | EDITING: cell is not updated when referenced cell becomes empty due to sort | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | mat.schult |
Component: | Calc | Assignee: | Eike Rathke <erack> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | cno, jbfaure, markus.mohrhard |
Priority: | medium | Keywords: | regression |
Version: | 4.1.0.0.beta1 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:4.1.4 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 60270, 85490 |
Description
mat.schult
2013-10-23 21:28:59 UTC
thanks mat! First version that shows it (that I have) is 4.1.0.0 beta1 Hi Mat, I had the change to test it in a master build: http://dev-builds.libreoffice.org/daily/master/ works fine there. Could you pls check that too? thanks, Cor @Moggi: Maybe you know off the top of your head what commit(s) to master could have fixed that? (In reply to comment #3) > @Moggi: > Maybe you know off the top of your head what commit(s) to master could have > fixed that? I would assume some of Kohei's rework. But I did not touch calc core mouch since the end of June. Fix pending review at https://gerrit.libreoffice.org/6516 Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e271ea0dceca3f8ac664246ef2f9d65b2fa360a8&h=libreoffice-4-1 resolved fdo#70815 broadcast emptied cell in ScColumn::SwapRow() It will be available in LibreOffice 4.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Does not work in 4.3.4.0.0+ : after sort B2 contains =A1 and shows the value 1 Works in 4.2.6.3 : after sort B2 contains =A2 and shows the value 0 Works in 4.4.0 alpha if the configuration option "Update references when sorting range of cells" is not checked. If the configuration option is checked, same behavior as 4.3.4.0.0+ See bug 81309 and bug 81633. Best regards. JBF Now, works as expected (as explained in the bug description) in version 4.3.4.0.0+ with the default configuration option (UpdateReferenceOnSort = false) added for bug 81633 (see: https://bugs.freedesktop.org/show_bug.cgi?id=81633#c50). Current behavior in 4.3.4.0.0+ and 4.4.0.0.alpha1+ : UpdateReferenceOnSort = true => after sort B2 contains the formula =A1 and show the value 1 ; correct because A1 contains the value 1. UpdateReferenceOnSort = false => after sort B2 contains the formula =A2 and show the value 0 ; correct because A0 contains nothing. Both behaviors are consistent and the choice between them is arbitrary, the test file does not give any insight of which should be chosen in this case. Best regards. JBF |