| Summary: | outline view is toast in 4.2 | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Caolán McNamara <caolan.mcnamara> |
| Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | agomez, jaragunde, vmiklos |
| Priority: | medium | ||
| Version: | 4.2.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 65675 | ||
| Attachments: | busted outline, text overlaps image | ||
|
Description
Caolán McNamara
2013-09-17 13:32:06 UTC
triggered by 43b84bbba2519686eb6b0463f422bf695d2d74b9 I believe The problem is triggered by the change from 3990 to #define OWN_ATTR_VALUE_END 3991 of include/svl/solar.hrc in 43b84bbba2519686eb6b0463f422bf695d2d74b9 there must be overlapping ids in there somewhere :-( oh god, what is this vomit in EditEngineItemPool::EditEngineItemPool e.g. aV5Map Strange, last time OWN_ATTR_VALUE_END was modified in 5924454a867bd500fdc696bb9939c84425c5e025, no editeng change was necessary, as far as I see. Regarding the editeng hardwired which ids, I believe those are (were?) used for some kind of binary import/export, 305c3ee0d0b4c49de8e8829a99da9a17063363a9 is an example on how a new map can be added when the ids change. But I suspect the problem is somewhere else, if no mapfile was added for 5924454a867bd500fdc696bb9939c84425c5e025, either. One more interesting thing is that if OWN_ATTR_VALUE_END is changed back to 3990, then everything is fine (no failing unit tests, even if code added by 43b84bbba2519686eb6b0463f422bf695d2d74b9 is covered by unit tests; also outline view is OK). But I guess we want to know exactly what relies on an unchanged OWN_ATTR_VALUE_END and fix *that* instead. Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a0248f89048fb3d85696eddbbcb2c176bc468c5 Resolves: fdo#69467 nTxtLeft not compared in operator== The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. v. fishy |