| Summary: | [Sidebar] Large icons are not used | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | ape <idler.1st> |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED INVALID | ||
| Severity: | normal | CC: | idler.1st, jbfaure, ny.nathan.yee, philipz85, xiscofauli |
| Priority: | medium | ||
| Version: | 4.1.0.2 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=82943 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103428, 103459 | ||
| Attachments: | Diff causing `undefined reference' errors. | ||
Large icons are unsuitable for the Properties panel, because a large number of object properties need to fit in this panel, with the aim being to completely replace formatting dialogs in the long run. Supporting two types of icon sizes in the sidebar is also much more complex in the sidebar compared to the toolbar, as the layout is easily breakable. (That could, however, be fixed by designing a more flexible sidebar layout.) The sidebar uses the widget layout technique, so I wouldn't be that pessimistic; I guess worth trying as an Easy Hack, and then let's see. * the setting if the current symbols are large can be obtained via: SvtMiscOptions().AreCurrentSymbolsLarge() * the sidebar toolbars that are created via .ui files are created in vcl/source/window/builder.cxx, search for GtkToolbar * with that in mind, calling SetToolboxButtonSize() on the newly created ToolBox in builder.cxx should hopefully do it :-) That should be enough for testing; if it proves to be a good change, then it of course needs testing whether it changes the size when the user changes the settings (I suspect not, but maybe I am wrong), etc. I am working on this bug. I've tried to use "pWindow->SetToolboxButtonSize(TOOLBOX_BUTTON_SIZE);" but I get an error "'class vcl::Window' has no member named 'SetToolboxButtonSize'". As pWindow is a vcl::Window* instantiated as a ToolBox, it seems strange that pWindow wouldn't have the SetToolbarButtonSize member function. Can someone lead me in the right direction with this? Created attachment 114260 [details]
Diff causing `undefined reference' errors.
I believe that I have managed to solve my previous problem by downcasting with dynamic_cast. However, I am now getting many "undefined reference to `SvtMiscOptions::xxx' errors, but it seems like I am correctly using "SvtMiscOptions().AreCurrentSymbolsLarge()". I've attached my current changes to the code, and any help would be much appreciated.
Dear Bug Submitter, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INVALID due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/FDO/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team This NEEDINFO message was generated on: 2015-10-14 Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicUI) [NinjaEdit] JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit] Dear Bug Submitter, Please read this message in its entirety before proceeding. Your bug report is being closed as INVALID due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team This INVALID Message was generated on: 2016-05-09 @Xisco: I think this bug report was closed by mistake. The question of comment #4 should have been sent back to the developer list. Best regards. JBF |
The parameter "Large" (Options - View - User_Interface - Icon_size) isn't work in the window "Sidebar". Large icons are not used, but they are in "images_{}.zip\cmd\..; ..\sc,sw\res\sibebar\..; ..\sfx2,svx\res\symphony\.."-files.