Summary: | replace SUPD variable ... | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Michael Meeks <michael.meeks> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | librelegal, robinson.libreoffice, roxana_ciobanu93 |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
Version: | 4.0.0.3 release | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | target:4.4.0 | ||
Crash report or crash signature: | Regression By: |
Description
Michael Meeks
2013-02-11 20:31:40 UTC
Hey, I would be interested in doing this clean up. This would be my first contribution to open source, if at all possible. Can I get more information on how to proceed on this bug? Thanks Rashid Hi Rashid - you need to read my comment which contains everything you need. git grep 'SUPD' and read around the code / instances of its use - it is a pre-processor define. Then read the config/config_version.h header - then consider how to migrate away from SUPD everywhere :-) A chunk of code-reading is necessary before almost any hack :-) Hi Rashid, Are you still working on this bug? If not, I can work on this or let this to someone work in our HackDay in May, 18 :) Michael, while doing git grep 'SUPD' | grep -w 'SUPD' I get a entry in doxygen config file solenv/inc/doxygen.cfg: SUPD=300 \ What we can do in this case? And, in configure.ac we define -DSUPD=$(UPD) And UPD is UPD="${LIBO_VERSION_MAJOR}${LIBO_VERSION_MINOR}0" And we have the SOURCEVERSION="OOO$UPD" That is used just once in the exported variable as export WORK_STAMP=@SOURCEVERSION@ That it's used in two perl files: solenv/bin/modules/installer/control.pm: WORK_STAMP solenv/bin/modules/installer/environment.pm: $installer::globals::build = $environment->{'WORK_STAMP'}; The first file take the value of the env variable I don't speak perl, but it seems that the second one uses the value of the same env variable. What we can do in these cases? (Sorry about all these questions :) ) SUPD is mostly gone: http://opengrok.libreoffice.org/search?q=SUPD&project=core&defs=&refs=&path=&hist= @Michael: Can we close this and if not, can you answer the questions from Comment 4? Well - the task is not yet complete; wrt. answering the questions: the goal is to remove SUPD and other versioning info that is not covered in config_version.h I see no non-C/C++ code using SUPD in master - so, there should be no big issue here. The doxygen.cfg line can be removed without issues I think. SUPD=420 for 4.2.0 - should be easy to make that work with the version macros. adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started This bug fix comes with LibreOffice 4.4 and is mentioned in the release notes (https://wiki.documentfoundation.org/ReleaseNotes/4.4) Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup) [NinjaEdit] Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit] |