| Summary: | VIEWING: Text range annotation limited to a single paragraph | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Alexandre Demers <alexandre.f.demers> |
| Component: | UI | Assignee: | Miklos Vajna <vmiklos> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | courrier.oou.fr.mjk, gerry.treppel, michael.meeks, olivier.dev, pjotr, tczillay, vmiklos |
| Priority: | medium | ||
| Version: | 4.0.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | BSA target:4.1.0 target:4.0.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | 38244 | ||
| Bug Blocks: | |||
| Attachments: | trivial reproducer | ||
|
Description
Alexandre Demers
2012-08-13 15:09:57 UTC
Confirmed. Is there any chance that this bug gets fixed for LibreOffice 4.0? I am very glad that Miklos added the possibility to assign comments to text ranges, but it is IMHO just half a feature if it does not allow to assign it to multiple paragraph text ranges. Example scenario: Think for example of bullet point lists in a document (each bullet point is a paragraph) and try to comment - let's say - bullet points number 3 to 5 telling the author that they should be deleted out or changed. This is not possible with the fix to bug 38244. It seems to me that if I add an annotation to multiple paragraphs those paragraphs end up rendered grey: ie. the are rendered as a 'field' (the new field support emphatically allows arbitary content - even tables, images etc. AFAIR). So ... my hope is that the infrastructure is there for creating and rendering multi-paragraph range comments - but of course, it prolly needs some more research & tweaking. Agreed, I checked what's the situation with this, and it seems the document model handles multi-paragraph comments just fine, only layout does not. Of course, once layout handles it, we need to check filters as well, I only checked that docx export handles two paragraphs fine. So yes, I plan to look into this. For the reference, bug 60769 tracked the ODF filter part of this, I checked that ODF import and OOXML filters handle multi-para comments properly. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=82b29b9d384211061653f35695287be60dbc99b8 fdo#53442 SwTxtPaintInfo::_DrawBackBrush: color multi-para comment ranges The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 77112 [details]
trivial reproducer
Trivial reproducer, the first line of the comment was gray, not blue.
4-0 review: https://gerrit.libreoffice.org/3094 Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=acd3b0da305fd6bf52a3d4cb6beb1d5702f68249&h=libreoffice-4-0 fdo#53442 SwTxtPaintInfo::_DrawBackBrush: color multi-para comment ranges It will be available in LibreOffice 4.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 61249 has been marked as a duplicate of this bug. *** Added info on this to the 4.1 release notes: https://wiki.documentfoundation.org/ReleaseNotes/4.1#Writer Please cross-check. Looks good, thanks! |