Summary: | [CRASH] legacy reports: asks for parameters, then for empty parameters list then CRASH | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Renato S. Yamane <renatoyamane> |
Component: | Base | Assignee: | Lionel Elie Mamane <lionel> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | iplaw67 |
Priority: | medium | Keywords: | regression |
Version: | 3.5.5.2 rc | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | target:3.7.0 target:3.6.0.0.beta3 target:3.5.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 37361 | ||
Attachments: |
File to reproduce this bug report
trace after crash screenshot of "asking for parameters" dialog Yamane trace after crash apple crash report trace |
Description
Renato S. Yamane
2012-07-01 08:18:53 UTC
Can not reproduce on LO 3.4.4 64bit Linux Mint, but will try on a more recent version. Alex Can not reproduce either in : LibreOffice 3.5.4.2 Build ID: 165a79a-7059095-e13bb37-fef39a4-9503d18 Linux Mint 12, 64bit Alex Confirming on 3.5.5.2 RC Linux Mint 13, 64bit # Problematic frame: # C [libdbulo.so+0x26c5be] std::vector<dbaui::OIndexField, std::allocator<dbaui::OIndexField> >::_M_fill_insert(__gnu_cxx::__normal_iterator<dbaui::OIndexField*, std::vector<dbaui::OIndexField, std::allocator<dbaui::OIndexField> > >, unsigned long, dbaui::OIndexField const&)+0xb9e Attaching trace Marking as regression, no crash in 3.5.4 Alex Created attachment 63679 [details]
trace after crash
Assigning to you Lionel, if it isn't your thing, just reset the default. Alex Reproduced with my development tree (libreoffice-3-5 branch). First time, the parameter "Cidade" is asked. But second time, the parameters list is empty. Renato and Alex, do you really get asked *twice* for the Cidade parameter, or is the parameter list empty for you also the second time? Heh, on my Mac dev build : version 3.6.0alpha0+ (Build ID: 4ccb4bd) The crash does not happen... will have to download a 3.5.5 RC2 to test on Mac. Alex (In reply to comment #6) Hi Lionel, > Reproduced with my development tree (libreoffice-3-5 branch). > > First time, the parameter "Cidade" is asked. > > But second time, the parameters list is empty. Renato and Alex, do you really > get asked *twice* for the Cidade parameter, or is the parameter list empty for > you also the second time? Not in front of machine at the moment, but I seem to recall that it did ask for data entry a second time before crashing. Will have to check later. Alex (In reply to comment #7) > Heh, on my Mac dev build : > version 3.6.0alpha0+ (Build ID: 4ccb4bd) > The crash does not happen... But you still get two "please enter parameters" dialogs? Only, it does not crash? (In reply to comment #8) > (In reply to comment #6) >> Reproduced with my development tree (libreoffice-3-5 branch). >> First time, the parameter "Cidade" is asked. >> But second time, the parameters list is empty. Renato and Alex, do you really >> get asked *twice* for the Cidade parameter, or is the parameter list empty for >> you also the second time? > Not in front of machine at the moment, but I seem to recall that it did ask for > data entry a second time before crashing. Will have to check later. Yes, but the point is that it asks for data entry, but the second time the list of parameters it asks data entry for is empty. In the screenshot, the area in red has "Cidade" the first time (like in screenshot), but is all empty the second time. Created attachment 63700 [details]
screenshot of "asking for parameters" dialog
Created attachment 63702 [details] Yamane trace after crash (In reply to comment #6) > First time, the parameter "Cidade" is asked. > > But second time, the parameters list is empty. Renato and Alex, do you really > get asked *twice* for the Cidade parameter, or is the parameter list empty for > you also the second time? First time the parameter is asking about "Cidade" parameter, and the second time is EMPTY. (In reply to comment #11) > > But second time, the parameters list is empty. Renato and Alex, do you really > > get asked *twice* for the Cidade parameter, or is the parameter list empty for > > you also the second time? > > First time the parameter is asking about "Cidade" parameter, and the second > time is EMPTY. Yes, confirming also on Mac OSX with LO 3.5.5 RC2. The second dialogue shows an empty parameter list. Alex Created attachment 63703 [details]
apple crash report trace
Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c34ef6b710bd9f3a5beac3be856c970c70e68610 fdo#51619 do not ask for parameters if all have already been given Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "libreoffice-3-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=961564738d846973344d976f21a61c40ba549fc0&g=libreoffice-3-6 fdo#51619 do not ask for parameters if all have already been given It will be available in LibreOffice 3.6. (In reply to comment #12) > (In reply to comment #11) >>> But second time, the parameters list is empty. Renato and Alex, do you really >>> get asked *twice* for the Cidade parameter, or is the parameter list empty for >>> you also the second time? >> First time the parameter is asking about "Cidade" parameter, and the second >> time is EMPTY. > Yes, confirming also on Mac OSX with LO 3.5.5 RC2. The second dialogue shows an > empty parameter list. Great! This means I have reproduced the same problem as this bug, and that my fix is complete. Asking for review to apply to libreoffice-3-5 (In reply to comment #15) > fdo#51619 do not ask for parameters if all have already been given > > It will be available in LibreOffice 3.6. Is there a way to push to 3.5.5? Is not good a CRASH in a stable release :-( (In reply to comment #16) > Great! This means I have reproduced the same problem as this bug, and that my > fix is complete. Asking for review to apply to libreoffice-3-5 Excellent, well done ! Here's hoping it gets the green light for backporting too :-) Alex (In reply to comment #17) > Is there a way to push to 3.5.5? > Is not good a CRASH in a stable release :-( Adding a fix to stable release branch (3.5.x) needs review by other developers. I asked for such review, it can take a few days to happen. I'm pretty sure the fix will be in 3.5.6 (to be released in September). For 3.5.5, it is *very* late, and it would mean delaying the release of 3.5.5 and I'm not sure we will do that. I'm putting this bug as "blocker" to put it on the release people's agenda, so that it gets *considered*, but the decision might be to delay the fix for 3.5.6. See http://wiki.documentfoundation.org/Release_Criteria#Blocker_Bug_Definition for a definition of what's allowed to block a release. All criteria are clearly met, except maybe: * problem must affect most users or there must not be a reasonable workaround; it is bad to block the release and all users because of a corner case when a reasonable workaround exists Does it affect "most users"? The question is whether most users use Base at all and queries with parameters in particular. <shrug> Alternatively, the "there must not be a reasonable workaround". The only work-around I can think if is not using parameters in queries for reports, but to change the underlying query every time. E.g. instead of: SELECT * FROM "Clients" WHERE "Cidade" = ? use SELECT * FROM "Clients" WHERE "Cidade" = 'London' And change 'London' to anything else you want when you want something else than London. That's rather onerous, but it works. Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "libreoffice-3-5": http://cgit.freedesktop.org/libreoffice/core/commit/?id=578128bea222938a38a1fa979264464e5e9ba4b0&g=libreoffice-3-5 fdo#51619 do not ask for parameters if all have already been given It will be available in LibreOffice 3.5.6. Testing on 3.5.3 and 3.5.4 (on *WINDOWS*), when I click on REPORT, the input field don't appear and the report is empty. (In reply to comment #21) > Testing on 3.5.3 and 3.5.4 (on *WINDOWS*), when I click on REPORT, the input > field don't appear and the report is empty. Please, in the comments of ONE bug don't discuss other bugs. What you describe seems to be bug 47473. If not, please file a *new* bug and put me on CC of that new bug. Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "libreoffice-3-5-5": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a3744b78b52c403630eff81c756ba1543e9c84b&g=libreoffice-3-5-5 fdo#51619 do not ask for parameters if all have already been given It will be available already in LibreOffice 3.5.5. (In reply to comment #23) > It will be available already in LibreOffice 3.5.5. Amazing! Thanks for your great job! |