Summary: | VIEWING: IDE Crash because Object Catalog not updated when closing a document | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | pierre-yves samyn <pierre-yves.samyn> |
Component: | UI | Assignee: | Uray M. János <uray.janos> |
Status: | RESOLVED FIXED | ||
Severity: | critical | ||
Priority: | high | ||
Version: | Master old -3.6 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | BSA target:3.7.0 target:3.6.1 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
Screenshot after step 5
Screenshot after step 6 Spreadsheet with 2 macros [PATCH] |
Hello Still occurs with Windows 7 64bits & Version 3.6.0.0.beta2 (Build ID: f010139) Regards Pierre-Yves (In reply to comment #1) > Still occurs with Windows 7 64bits & Version 3.6.0.0.beta2 (Build ID: f010139) The non-updating catalog causes a crash in the following case: 1. Open the attached spreadsheet (BugCatalogObject.ods) 2. Tools> Macros> Organize Macros> LODev Basic> BugCatalogObject> Standard> Module1> Main1> Edit Expected & Actual results : IDE opens, 3 items in the object catalog (My macros, LODev Macros, BugCatalogObject) 3. In the left panel (catalog) unfold BugCatalogObject> Standard> Module1, then double-click Main2 4. Windows> BugCatalogObject.ods (spreadsheet document to front) 5. File> Close (close BugCatalogObject & return to IDE) Expected result : object catalog updated, only 2 items (My macros, LODev Macros) Actual result Regression : object catalog not updated, still 3 items (My macros, LODev Macros, BugCatalogObject) This is the Issue described above, now the crash : 6. In the left panel (catalog) double-click on BugCatalogObject> Standard> Module1> Main1 Note: this should not be possible if the catalog was updated Actual result : Crash (see Screenshot after step 6) Regards Pierre-Yves Created attachment 63655 [details]
Screenshot after step 6
Created attachment 63656 [details]
Spreadsheet with 2 macros
Still occurs with Windows 7 64bits & Version 3.6.0.0.beta3 (Build ID: 3e2b862) Still occurs with Windows 7 64bits & Version 3.6.0.1 (Build ID: 73f9fb6) Created attachment 64643 [details]
[PATCH]
The Object Catalog was not updated, because at the point when onDocumentClosed() event was generated in BasicTreeListBox, the to-be-closed document is still alive, so UpdateEntries() doesn't remove the entry. I removed this entry manually in onDocumentClosed().
Uray M. János
Uray M. Janos committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb66a2c3ee9807e79ba437c770559787abe61b9b fdo#50632 IDE: update Object Catalog when closing a document Uray M. Janos committed a patch related to this issue. It has been pushed to "libreoffice-3-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3784488acbe16c4581e164e3c9a0af9ad57c1cef&g=libreoffice-3-6 fdo#50632 IDE: update Object Catalog when closing a document It will be available in LibreOffice 3.6.1. Hello WORKSFORME with Version 3.6.1.2 (Build ID: e29a214) & windows 7 64bits Regards Pierre-Yves |
Created attachment 62444 [details] Screenshot after step 5 Hello Steps to reproduce: 1. Start LibO 2. File> New> Text document (document's type doesn't matter) 3. Tools> Macros> Organize Macros> LODev Basic> My Macros> Standard> Edit Expected & Actual results : IDE opens, 3 items in the object catalog (My macros, LODev Macros, Untitled1) 4. Windows> Untitled (untitled document to front) 5. File> Close (close untitled document & return to IDE) Expected result : object catalog updated, only 2 items (My macros, LODev Macros) Actual result : object catalog not updated, still 3 items (My macros, LODev Macros, Untitled1) See screenshot after step 5 Platform : version 3.6.0alpha0+ (Build ID: b5f066) Browser: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.52 Safari/536.5 Regards Pierre-Yves